spurious UT failure 'L3_ROUTER_NAT' keyerror

[Kevin Benton]

Getting random failures.[1]

2015-03-19 16:30:14.549 | neutron.tests.unit.test_extension_ext_gw_mode.ExtGwModeIntTestCase.test_router_create_show_ext_gwinfo_default
2015-03-19 16:30:14.549 | -------------------------------------------------------------------------------------------------------------
2015-03-19 16:30:14.550 |
2015-03-19 16:30:14.550 | Captured traceback:
2015-03-19 16:30:14.550 | ~~~~~~~~~~~~~~~~~~~
2015-03-19 16:30:14.550 | Traceback (most recent call last):
2015-03-19 16:30:14.550 | File "neutron/tests/unit/test_extension_ext_gw_mode.py", line 320, in setUp
2015-03-19 16:30:14.550 | service_plugins=svc_plugins)
2015-03-19 16:30:14.550 | File "neutron/tests/unit/test_db_plugin.py", line 159, in setUp
2015-03-19 16:30:14.550 | self.ext_api = test_extensions.setup_extensions_middleware(ext_mgr)
2015-03-19 16:30:14.550 | File "neutron/tests/unit/test_extensions.py", line 649, in setup_extensions_middleware
2015-03-19 16:30:14.550 | return extensions.ExtensionMiddleware(app, ext_mgr=extension_manager)
2015-03-19 16:30:14.551 | File "neutron/api/extensions.py", line 276, in __init__
2015-03-19 16:30:14.551 | for resource in self.ext_mgr.get_resources():
2015-03-19 16:30:14.551 | File "neutron/tests/unit/test_extension_ext_gw_mode.py", line 53, in get_resources
2015-03-19 16:30:14.551 | return l3.L3.get_resources()
2015-03-19 16:30:14.551 | File "neutron/extensions/l3.py", line 204, in get_resources
2015-03-19 16:30:14.551 | register_quota=True)
2015-03-19 16:30:14.551 | File "neutron/api/v2/resource_helper.py", line 68, in build_resource_info
2015-03-19 16:30:14.551 | plugin = manager.NeutronManager.get_service_plugins()[which_service]
2015-03-19 16:30:14.551 | KeyError: 'L3_ROUTER_NAT'
2015-03-19 16:30:14.551 |

1. http://logs.openstack.org/61/152761/21/check/gate-neutron-python27/d29809b/console.html

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/166014
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=387f396db83179ce109162022ab23e0c8b59c9bf
Submitter: Jenkins
Branch: master

commit 387f396db83179ce109162022ab23e0c8b59c9bf
Author: Kevin Benton <email address hidden>
Date: Wed Mar 18 08:14:09 2015 -0700

    Make DHCP tests cleanup neutron manager reference

    The DHCP scheduler unit tests occasionally call methods
    on the core plugin via the neutron manager (e.g. in report_state).
    However, they weren't calling the normal unit test cleanup routines
    for tests that call the core plugin so they were leaving stale
    references in the manager.

    This patch uses the setup_coreplugin helper that sets up the
    configuration for the core plugin and adds the cleanup call
    to ensure that the neutron manager is cleaned up at the end
    of each test.

    Closes-Bug: #1434278
    Change-Id: Ic35629659574121c739574c1ed39364d6977c3ea