DVR: metada network not created for NSX-mh

[Salvatore Orlando]

When creating a distributed router, instances attached to it do not have metadata access.

This is happening because the metadata network is not being created and connected to the router - since the process for handling metadata network has not been updated with the new interface type for DVR router ports.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/165387

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/165387
Committed: https://git.openstack.org/cgit/stackforge/vmware-nsx/commit/?id=e248f87867a74722df243598d6a6d707170ca5ce
Submitter: Jenkins
Branch: master

commit e248f87867a74722df243598d6a6d707170ca5ce
Author: Salvatore Orlando <email address hidden>
Date: Wed Mar 18 04:58:25 2015 -0700

    Fix DVR for NSX-mh

    The switch to the community management layer mixin introduced
    several bugs in the NSX-mh plugins.

    This patch:
    1) Stops creating centralized SNAT interfaces for NSX distributed
       routers. The NSX backend does not need those and they therefore
       only waste IPs and create confusion. This is done by providing
       an empty implementation for the relevant methods.
    2) Does not query l3-agents when removing router interface. This
       is causing errors during interface removal and preventing router
       removal, as the NSX plugin does not use l3 agents at all.
       This patch provides an empty implementation for the relevant
       method thus preventing the DVR mixin from doing any sort of
       operations pertaining l3 agents.
    3) It ensures DVR router interfaces are taken into account in the
       management of metadata network for routers.

    Change-Id: I149307ff67e464e78ae393bb57c25bbee607ee4b
    Closes-Bug: #1433550
    Closes-Bug: #1433553
    Closes-Bug: #1433554

[Salvatore Orlando (salvatore-orlando)]

Addressed for stable/juno by: https://review.openstack.org/167295

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/174020

[OpenStack Infra (hudson-openstack)]

Change abandoned by Salvatore Orlando (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/167295
Reason: new change-id meant new change

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/174020
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fc0ae03e2198d826f8861e2d427864708fda9136
Submitter: Jenkins
Branch: stable/juno

commit fc0ae03e2198d826f8861e2d427864708fda9136
Author: Salvatore Orlando <email address hidden>
Date: Wed Mar 18 13:18:25 2015 -0700

    VMware NSX: Fix DVR operations

    The switch to the community management layer mixin introduced
    several bugs in the NSX-mh plugins.
    This patch:
    1) Stops creating centralized SNAT interfaces for NSX distributed
       routers. The NSX backend does not need those and they therefore
       only waste IPs and create confusion. This is done by providing
       an empty implementation for the relevant methods.
    2) Does not query l3-agents when removing router interface. This
       is causing errors during interface removal and preventing router
       removal, as the NSX plugin does not use l3 agents at all.
       This patch provides an empty implementation for the relevant
       method thus preventing the DVR mixin from doing any sort of
       operations pertaining l3 agents.
    3) It ensures DVR router interfaces are taken into account in the
       management of metadata network for routers.

    Applied for stackforge/vmware-nsx commit id:
    e248f87867a74722df243598d6a6d707170ca5ce

    Change-Id: I149307ff67e464e78ae393bb57c25bbee607ee4b
    Closes-Bug: #1433550
    Closes-Bug: #1433553
    Closes-Bug: #1433554