migrate non-dvr to dvr case, snat netns not created

Bug #1428713 reported by ZongKai LI
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Oleg Bondarev

Bug Description

On a 1+2 env, router has external network attached.
Use follow steps to migrate from non-dvr to dvr:
1) modify related config files.
2) restart related services.
3) run command "neutron router-update --distributed=True ROUTER".

Now, there's no snat-* netns create on controller node.
As a workaround, restart neutron-l3-agent on controller node will work.

And in l3-agent.log, we can find:
2015-02-28 01:26:21.377 5283 ERROR neutron.agent.l3.agent [-] 'LegacyRouter' object has no attribute 'dist_fip_count'
2015-02-28 01:26:21.377 5283 TRACE neutron.agent.l3.agent Traceback (most recent call last):
2015-02-28 01:26:21.377 5283 TRACE neutron.agent.l3.agent File "/usr/lib/python2.7/site-packages/neutron/common/utils.py", line 342, in call
2015-02-28 01:26:21.377 5283 TRACE neutron.agent.l3.agent return func(*args, **kwargs)
2015-02-28 01:26:21.377 5283 TRACE neutron.agent.l3.agent File "/usr/lib/python2.7/site-packages/neutron/agent/l3/agent.py", line 592, in process_router
2015-02-28 01:26:21.377 5283 TRACE neutron.agent.l3.agent self.scan_fip_ports(ri)
2015-02-28 01:26:21.377 5283 TRACE neutron.agent.l3.agent File "/usr/lib/python2.7/site-packages/neutron/agent/l3/dvr.py", line 128, in scan_fip_ports
2015-02-28 01:26:21.377 5283 TRACE neutron.agent.l3.agent if not ri.router.get('distributed') or ri.dist_fip_count is not None:
2015-02-28 01:26:21.377 5283 TRACE neutron.agent.l3.agent AttributeError: 'LegacyRouter' object has no attribute 'dist_fip_count'

It seems current code is not ready to migrate LegacyRouter to DvrRouter.

ZongKai LI (zongkai)
Changed in neutron:
assignee: nobody → ZongKai LI (lzklibj)
Revision history for this message
Xu Han Peng (xuhanp) wrote :

I think my patch https://review.openstack.org/#/c/151153/ fix this problem.

Revision history for this message
ZongKai LI (zongkai) wrote :

Hi, Xu Han, I checked your patch. Yes, it will make the error log raise no longer, and it should check whether ri has that attribute.
But as your commit message says, it should be a problem LegacyRouter migrate to DvrRouter. As a long sight, migrate ri from LegacyRouter to DvrRouter should be a better way.
Btw, the entrance to a serial of invoking to create snat netns should be _process_external in process_router in l3/agent.py

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/162117

Changed in neutron:
status: New → In Progress
Revision history for this message
ZongKai LI (zongkai) wrote :

The commands to update router in DVR migration should be:
neutron router-update --admin_state_up=False ROUTER
neutron router-update --distributed=True ROUTER
neutron router-update --admin_state_up=True ROUTER

Changed in neutron:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by ZongKai LI (<email address hidden>) on branch: master
Review: https://review.openstack.org/162117

Revision history for this message
Oleg Bondarev (obondarev) wrote :

I think we need to add explicit validation for router being set to admin state down prior to upgrade.
This should eliminate the confusion.

Changed in neutron:
status: Invalid → Triaged
assignee: ZongKai LI (lzklibj) → Oleg Bondarev (obondarev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/214097

Changed in neutron:
status: Triaged → In Progress
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/214097
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9a4f2e51a5b8f6f96535ee6968e5a209dd518654
Submitter: Jenkins
Branch: master

commit 9a4f2e51a5b8f6f96535ee6968e5a209dd518654
Author: Oleg Bondarev <email address hidden>
Date: Tue Aug 18 12:48:41 2015 +0300

    Validate router admin_state_up on upgrade to distributed

    For proper upgrade of centralized router to distributed the router
    needs to be disabled (admin_state_up set to false).
    The patch adds corresponding validation.

    Closes-Bug: #1428713
    Change-Id: Idf25db0936eee892ecb169a8678ba7f0a2cfceb6

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/218710

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/pecan)
Download full text (155.6 KiB)

Reviewed: https://review.openstack.org/218710
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2c5f44e1b3bd4ed8a0b7232fd293b576cc8c1c87
Submitter: Jenkins
Branch: feature/pecan

commit f35d1c5c50dccbef1a2e079f967b82f0df0e22e9
Author: Adelina Tuvenie <email address hidden>
Date: Thu Aug 27 02:27:28 2015 -0700

    Fixes wrong neutron Hyper-V Agent name in constants

    Change Id03fb147e11541be309c1cd22ce27e70fadc28b5 moved the
    AGENT_TYPE_HYPERV constant from common.constants to
    plugins.ml2.drivers.hyperv.constants but change the value of the
    constant from 'HyperV agent' to 'hyperv'. This patch changes
    the name back to 'HyperV agent'

    Change-Id: If74b4b2a84811e266c8b12e70bf6bfe74ed4ea21
    Partial-Bug: #1487598

commit de604de334854e2eb6b4312ff57920564cbd4459
Author: OpenStack Proposal Bot <email address hidden>
Date: Sun Aug 30 01:39:06 2015 +0000

    Updated from global requirements

    Change-Id: Ie52aa3b59784722806726e4046bd07f4a4d97328

commit f0415ac20eaf5ab4abb9bd4839bf6d04ceee85d0
Author: armando-migliaccio <email address hidden>
Date: Fri Aug 28 13:53:04 2015 -0700

    Revert "Add support for unaddressed port"

    This implementation may expose a vulnerability where a malicious
    user can sieze the opportunity of a time window where a port
    may land unaddressed on a shared network, thus allowing him/her
    to suck up all the tenant traffic he/she wants....oh the shivers.

    This reverts commit d4c52b7f5a36a103a92bf9dcda7f371959112292.

    Change-Id: I7ebdaa8d3defa80eab90e460fde541a5bdd8864c

commit 013fdcd2a6d45dbe4de5d6e7077e5e9b60985ef9
Author: Assaf Muller <email address hidden>
Date: Fri Aug 28 16:41:07 2015 -0400

    Improve logging upon failure in iptables functional tests

    This will help us nail down a more accurate and efficient logstash
    query.

    Change-Id: Iee4238e358f7b056e373c7be8d6aa3202117a680
    Related-Bug: #1478847

commit 622dea818d851224a43d5276a81d5ce8a6eebb76
Author: Ivar Lazzaro <email address hidden>
Date: Mon Aug 17 17:17:42 2015 -0700

    handle gw_info outside of the db transaction on router creation

    Move the gateway interface creation outside the DB transaction
    to avoid lock timeout.

    Change-Id: I5a78d7f32e8ca912016978105221d5f34618af19
    Closes-bug: 1485809

commit 5b27d290a0a95f6247fc5a0fe6da1e7d905e6b2d
Author: Assaf Muller <email address hidden>
Date: Wed Aug 26 10:07:03 2015 -0400

    Remove ml2 resource extension success logging

    This is the cause of a tremendous amount of logs, for no
    perceivable gain. A normal dvr run in the gate shows this debug
    message around 120K times, which is way too much.

    Closes-Bug: #1489952

    Change-Id: I26fca8515d866a7cc1638d07fa33bc04479ae221

commit 8d3faf549cba2f58c872ef4121b2481e73464010
Author: huangpengtao <email address hidden>
Date: Fri Aug 28 23:20:46 2015 +0800

    Replace "prt" variable by "port"

    the local variable prt is meaningless,
    and port is used popular.

    Change-Id: I20849102cf5b4d84433c46791b4b1e2a22dc4739

commit ee374e7a5f4dea538fcd942f5...

tags: added: in-feature-pecan
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-3 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.