dhcp _test_sync_state_helper does not assert calls properly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
Undecided
|
Edgar Magana |
Bug Description
There are a few problems with _test_sync_
1. calling assert_has_called() on a mock object does nothing - should be assert_has_calls()
2. sync_state() no longer calls refresh_
3. safe_configure_
4. it does a set diff between sets of different types
export NOSE_NOLOGCAPTURE=1
export OS_DEBUG=1
$ nosetests -v neutron.
...
2015-02-27 08:35:49,105 INFO [neutron.
2015-02-27 08:35:49,106 ERROR [neutron.
Traceback (most recent call last):
File "/opt/stack/
active_
File "/opt/stack/
active_
AttributeError: 'str' object has no attribute 'id'
2015-02-27 08:35:49,107 DEBUG [oslo_concurren
passed
Changed in neutron: | |
assignee: | nobody → Darragh O'Reilly (darragh-oreilly) |
status: | New → In Progress |
Changed in neutron: | |
assignee: | Darragh O'Reilly (darragh-oreilly) → Edgar Magana (emagana) |
Changed in neutron: | |
milestone: | none → liberty-1 |
status: | Fix Committed → Fix Released |
Changed in neutron: | |
milestone: | liberty-1 → 7.0.0 |
Fix proposed to branch: master /review. openstack. org/159756
Review: https:/