Consume oslo.log

Bug #1425013 reported by Ihar Hrachyshka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Ihar Hrachyshka

Bug Description

Now that oslo team officially released oslo.log, we should consume it.

http://lists.openstack.org/pipermail/openstack-dev/2015-February/057573.html

Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :
Changed in neutron:
milestone: none → next
assignee: nobody → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/159638

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/159654

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-vpnaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/159887

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-lbaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/159889

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-fwaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/159891

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/159891
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=148d8545781846bcebffbe42daaec838695f2a24
Submitter: Jenkins
Branch: master

commit 148d8545781846bcebffbe42daaec838695f2a24
Author: Ihar Hrachyshka <email address hidden>
Date: Fri Feb 27 16:34:07 2015 +0100

    Migrate to oslo.log

    This is just a matter of switching import paths and adding appropriate
    dependency.

    Related-Bug: #1425013
    Change-Id: I310e059a815377579de6bb2aa204de168e72571e

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-lbaas (master)

Reviewed: https://review.openstack.org/159889
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=4d58d51eeda18b833f935452bbd14d4c6e1e4783
Submitter: Jenkins
Branch: master

commit 4d58d51eeda18b833f935452bbd14d4c6e1e4783
Author: Ihar Hrachyshka <email address hidden>
Date: Fri Feb 27 16:24:38 2015 +0100

    Migrate to oslo.log

    This is just a matter of switching import paths and adding appropriate
    dependency.

    Related-Bug: #1425013
    Change-Id: I310e059a815377579de6bb2aa204de168e72571e

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-vpnaas (master)

Reviewed: https://review.openstack.org/159887
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=b746a0cd1a37fa211f092643a3824ddd6518e058
Submitter: Jenkins
Branch: master

commit b746a0cd1a37fa211f092643a3824ddd6518e058
Author: Ihar Hrachyshka <email address hidden>
Date: Fri Feb 27 16:00:42 2015 +0100

    Migrate to oslo.log

    This is just a matter of switching import paths and adding appropriate
    dependency.

    Related-Bug: #1425013
    Change-Id: I310e059a815377579de6bb2aa204de168e72571e

Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Marking for kilo since there seems to be consensus to consume it this cycle, and all *aas repos already consumed it, so we should not leave repos in the middle of migration path for Kilo release.

Changed in neutron:
milestone: next → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/159654
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a82357cc31dcdb71e4a88c75cb31e2cfabe3e97c
Submitter: Jenkins
Branch: master

commit a82357cc31dcdb71e4a88c75cb31e2cfabe3e97c
Author: Ihar Hrachyshka <email address hidden>
Date: Fri Feb 27 00:00:24 2015 +0100

    oslo: sync all modules that depend on incubator log module

    We're going to switch to oslo.log, so we need to untangle incubator
    modules from the old log module. This is achieved by synchronizing all
    the modules that used the module before from oslo-incubator.

    Note that incubator modules now use standard logging module (and not
    e.g. oslo.log).

    The following modules (and their dependencies) are synced:
    - eventlet_backdoor
    - fileutils
    - loopingcall
    - periodic_task
    - policy
    - service
    - systemd
    - threadgroup
    - versionutils

    The latest commit in oslo-incubator at the moment of sync is:
    - f989c4397d7e83c3e73e8da01a9f27bf4ca38b73

    Changes to modules are minor and hence are not expected to break
    anything.

    Change-Id: I360863a5a4fa6a179c6884cff84553a35d889719
    Related-Bug: #1425013

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/163207

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/163207
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=eb9819690b3fb5705e13963fba3ed3ef6cd9c153
Submitter: Jenkins
Branch: master

commit eb9819690b3fb5705e13963fba3ed3ef6cd9c153
Author: Ihar Hrachyshka <email address hidden>
Date: Tue Mar 10 22:57:58 2015 +0100

    Added oslo.log dependency

    This is needed for vendor libraries out of tree to start switching their
    code to oslo.log logging interface. Hopefully, they will be able to run
    against neutron core using neutron.openstack.common.log while executing
    oslo_log.log.* calls.

    Change-Id: I666389efe65526bda66c5f70170687638d1a5038
    Related-Bug: #1425013

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/159638
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=22328baf1f60719fcaa5b0fbd91c0a3158d09c31
Submitter: Jenkins
Branch: master

commit 22328baf1f60719fcaa5b0fbd91c0a3158d09c31
Author: Ihar Hrachyshka <email address hidden>
Date: Thu Feb 26 23:26:41 2015 +0100

    Migrate to oslo.log

    It's mostly a matter of changing imports to a new location.

    Non-obvious changes needed:
    * pass overwrite= argument to oslo_context since oslo.log reads context
      from its thread local store and not local.store from incubator
    * don't store context at local.store now that there is no code that
      would consume it
    * LOG.deprecated() -> versionutils.report_deprecated_feature()
    * dropped LOG.audit check from hacking rule since now the method does
      not exist
    * WritableLogger is now located in oslo_log.loggers

    Dropped log module from the tree. Also dropped local module that is now
    of no use (and obsolete, as per oslo team).

    Added versionutils back to openstack-common.conf since now we use the
    module directly from neutron code and not just as a dependency of some
    other oslo-incubator module.

    Note: tempest tests are expected to be broken now, so instead of fixing
    all the oslo.log related issues for the subtree in this patch, I only
    added TODOs with directions for later fix.

    Closes-Bug: #1425013
    Change-Id: I310e059a815377579de6bb2aa204de168e72571e

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.