TRACE when removing a floating IP from a DVR router that has no floating IPs

[Assaf Muller]

dvr_router.*.floating_ip_removed_dist tries to access self.local_subnets, which is a member of self.fip_ns.local_subnets.

[Mike Smith (michael-smith6)]

@Assaf - what are the steps to hit this issue? Or is it something you noticed in the code?

[Mike Smith (michael-smith6)]

Also - this is the code patch with the fix for this issue right? https://review.openstack.org/#/c/157621

[Assaf Muller (amuller)]

That's the patch correct. I just noticed this issue in the code. I remember I tried to figure out in what scenario would that if block actually be executed and it's not trivial.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/157621
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=974991db5528eb8b227eb883a1b1ef1a918e4d14
Submitter: Jenkins
Branch: master

commit 974991db5528eb8b227eb883a1b1ef1a918e4d14
Author: Assaf Muller <email address hidden>
Date: Thu Feb 19 19:59:21 2015 -0500

    Fix non-existent self.local_subnets in DvrRouter class

    Found via the pylint no-member check.

    Co-Authored-By: <email address hidden>

    Closes-Bug: #1423777
    Change-Id: I280948300810f199988a943aeb6577243423a4e7