TRACE when removing a floating IP from a DVR router that has no floating IPs

Bug #1423777 reported by Assaf Muller
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Mike Smith

Bug Description

dvr_router.*.floating_ip_removed_dist tries to access self.local_subnets, which is a member of self.fip_ns.local_subnets.

Changed in neutron:
assignee: nobody → Assaf Muller (amuller)
status: New → In Progress
Revision history for this message
Mike Smith (michael-smith6) wrote :

@Assaf - what are the steps to hit this issue? Or is it something you noticed in the code?

Revision history for this message
Mike Smith (michael-smith6) wrote :

Also - this is the code patch with the fix for this issue right?

Revision history for this message
Assaf Muller (amuller) wrote :

That's the patch correct. I just noticed this issue in the code. I remember I tried to figure out in what scenario would that if block actually be executed and it's not trivial.

Changed in neutron:
assignee: Assaf Muller (amuller) → Mike Smith (michael-smith6)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Submitter: Jenkins
Branch: master

commit 974991db5528eb8b227eb883a1b1ef1a918e4d14
Author: Assaf Muller <email address hidden>
Date: Thu Feb 19 19:59:21 2015 -0500

    Fix non-existent self.local_subnets in DvrRouter class

    Found via the pylint no-member check.

    Co-Authored-By: <email address hidden>

    Closes-Bug: #1423777
    Change-Id: I280948300810f199988a943aeb6577243423a4e7

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.