VPNaaS refactor service driver to reuse VpnDriver code

Bug #1422905 reported by Sridhar Ramaswamy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Sridhar Ramaswamy

Bug Description

Currently various VPN service-drivers in neutron-vpnaas repo doesn't reuse code which is same for most part. Topic connection creation and make_vpnservice_dict (again optional) are different for each service-driver. This came up during the code review of [1].

The proposal is to refactor this code to have a base class with a separate "create_rpc_connection" method which will be overridden by different service-driver implementations.

[1] https://review.openstack.org/#/c/154720/5/neutron_vpnaas/services/vpn/service_drivers/vyatta_ipsec.py,unified

Tags: vpnaas
Changed in neutron:
assignee: nobody → Sridhar Ramaswamy (srics-r)
Paul Michali (pcm)
Changed in neutron:
status: New → Confirmed
description: updated
tags: added: vpnaas
Changed in neutron:
status: Confirmed → In Progress
Changed in neutron:
assignee: Sridhar Ramaswamy (srics-r) → Numan Siddique (numansiddique)
Changed in neutron:
assignee: Numan Siddique (numansiddique) → Sridhar Ramaswamy (srics-r)
Kyle Mestery (mestery)
Changed in neutron:
importance: Undecided → High
milestone: none → kilo-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-vpnaas (master)

Reviewed: https://review.openstack.org/158516
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=62dffba3d75376a91f2b971f571cd749c04a78a5
Submitter: Jenkins
Branch: master

commit 62dffba3d75376a91f2b971f571cd749c04a78a5
Author: Sridhar Ramaswamy <email address hidden>
Date: Mon Feb 23 15:20:32 2015 -0800

    VPNaaS refactor service driver to reuse VpnDriver code

    Introduce BaseIPsecVpnDriver class to host most of the
    common code to be shared across various implementations
    of VPN service-drivers. This reduces the duplicate code
    in these service-drivers

    Closes-Bug: #1422905
    Related-Bug: #1423244
    Co-Authored-By: Numan Siddique <email address hidden>
    Change-Id: Ibde249af5c7228e2f9b7496cb03bd9b516966ef5

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.