pylint is failing in the check queue

[Carl Baldwin]

I'm getting a pylint error on my newest patch [2] that doesn't seem to be related to the patch. I seem to get the same error on master. Logstash is hinting at something starting to go wrong [1].

"Possible unbalanced tuple unpacking with sequence defined at line 153: left side has 2 label(s), right side has 0 value(s) (unbalanced-tuple-unpacking)"

 [1] http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwidW5iYWxhbmNlZCB0dXBsZSB1bnBhY2tpbmdcIiBBTkQgdGFnczpcImNvbnNvbGVcIiIsImZpZWxkcyI6W10sIm9mZnNldCI6MCwidGltZWZyYW1lIjoiNjA0ODAwIiwiZ3JhcGhtb2RlIjoiY291bnQiLCJ0aW1lIjp7InVzZXJfaW50ZXJ2YWwiOjB9LCJzdGFtcCI6MTQyMTQ0NzYyMTc4MiwibW9kZSI6IiIsImFuYWx5emVfZmllbGQiOiIifQ==
[2]https://review.openstack.org/#/c/147972

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/148024

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/148027

[Carl Baldwin (carl-baldwin)]

I also put this one up to consider making pylint non-voting [1]. Just for discussion.

[1] https://review.openstack.org/#/c/148026

[Carl Baldwin (carl-baldwin)]

Some notes...

I tried pinning to pylint 1.4.0 and I got an exception in pylint [1]. I repeated this a number of times after running "git clean -fdx". Then, I tried pinning pylint to 1.3.1 and I got the same error [2]. I thought that pinning back to what was there before today would be a slam dunk but apparently not.

The version I tested was b3db517a521cf1d4f2854101204702efda66ad9d.

[1] http://paste.openstack.org/show/158336/
[2] http://paste.openstack.org/show/158337/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/148024
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4906e0cf8e9123424d8d6e794a704e3e18f24689
Submitter: Jenkins
Branch: master

commit 4906e0cf8e9123424d8d6e794a704e3e18f24689
Author: Carl Baldwin <email address hidden>
Date: Fri Jan 16 23:40:13 2015 +0000

    Disable unbalanced-tuple-unpacking

    This check seems to have changed and started to break in Neutron.
    Disabling it is one way we could get back to good.

    Change-Id: I6d06d43cb2e78501cd69fcb3940694d04d936fa8
    Closes-bug: #1411865

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/148027
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c9974b9269e5e9943c7b920d9a0569dc80ddebb8
Submitter: Jenkins
Branch: master

commit c9974b9269e5e9943c7b920d9a0569dc80ddebb8
Author: Cedric Brandily <email address hidden>
Date: Fri Jan 16 23:41:16 2015 +0000

    Fix pylint unbalanced-tuple-unpacking warning

    Pylint last version(1.4.1), at least, reports an
    unbalanced-tuple-unpacking warning[1] in keepalived[2] module because
    self.authentication is defined as an empty tuple in __init__ method and
    unpacked in build_config method as if it was a 2-tuple.

    self.authentication references an empty tuple (defined in __init__
    method) or a 2-tuple (updated in set_authentication method). Such
    warning is a false positive because the unpacking is only performed if
    self.authentication is not evaluated to false which only appends if
    self.authentication is a 2-tuple.

    Defining self.authentication as None in __init__ avoids such warning
    without disabling unbalanced-tuple-unpacking warning check.

    [1]
    W:252,12: Possible unbalanced tuple unpacking with sequence defined at
    line 153: left side has 2 label(s), right side has 0 value(s)
    (unbalanced-tuple-unpacking)

    [2] neutron.agent.linux.keepalived

    Change-Id: Ifcdf08e574ef44a65c6d121323cbe31d9af2f921
    Closes-Bug: #1411865