Router interface should not be updated to have more ips

[Zhiyuan Cai]

When adding an interface to a router with a port, Neutron will check, and if that port has more than one fixed ips, Neutron will reject that request. However, we can still update a router port to have more than one fixed ips.

openstack@Openstack-Vega:~$ neutron router-port-list router1
+--------------------------------------+----------+-------------------+---------------------------------------------------------------------------------+
| id | name | mac_address | fixed_ips |
+--------------------------------------+----------+-------------------+---------------------------------------------------------------------------------+
| 358c58b8-9b74-4425-b38f-e17a47742488 | testport | fa:16:3e:cb:75:39 | {"subnet_id": "ffd2d8ad-7a27-4e59-b78b-508af54d3cb4", "ip_address": "10.0.0.6"} |
+--------------------------------------+----------+-------------------+---------------------------------------------------------------------------------+

openstack@Openstack-Vega:~$ neutron port-update testport --fixed-ips type=dict list=true ip_address=10.0.0.6 ip_address=10.0.0.7
Updated port: testport

openstack@Openstack-Vega:~$ neutron router-port-list router1
+--------------------------------------+----------+-------------------+---------------------------------------------------------------------------------+
| id | name | mac_address | fixed_ips |
+--------------------------------------+----------+-------------------+---------------------------------------------------------------------------------+
| 358c58b8-9b74-4425-b38f-e17a47742488 | testport | fa:16:3e:cb:75:39 | {"subnet_id": "ffd2d8ad-7a27-4e59-b78b-508af54d3cb4", "ip_address": "10.0.0.6"} |
| | | | {"subnet_id": "ffd2d8ad-7a27-4e59-b78b-508af54d3cb4", "ip_address": "10.0.0.7"} |
+--------------------------------------+----------+-------------------+---------------------------------------------------------------------------------+

[Armando Migliaccio (armando-migliaccio)]

This is because during the port-update we don't validate or look at port owners in relation to IP allocations.

[Kevin Benton (kevinbenton)]

If this is admin-only, do we care? Maybe we should just pull the restriction off of the create so we don't end up special-casing port-update code just for routers.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/147739

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kyle Mestery (<email address hidden>) on branch: master
Review: https://review.openstack.org/147739
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Armando Migliaccio (armando-migliaccio)]

This bug is > 365 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

[Launchpad Janitor (janitor)]

[Expired for neutron because there has been no activity for 60 days.]