Should use lazy logging interpolation

[Angus Lees]

There are a small number of examples of "eager" interpolation in
neutron:
  logging.debug("foo %s" % arg)

These should be converted to perform the interpolation lazily within
the logging function, since if the severity is below the logging level
then the interpolation can be skipped entirely.

This bug is a grab bag of all such current examples found in neutron
via a pylint test.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/143354

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/143355

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/143356

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/143357

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/143358

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/143359

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/143354
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7a006a83e9023740122b575a9518541ff57c1cb5
Submitter: Jenkins
Branch: master

commit 7a006a83e9023740122b575a9518541ff57c1cb5
Author: Angus Lees <email address hidden>
Date: Mon Dec 22 15:35:32 2014 +1100

    Use lazy logging interpolation

    There are a small number of examples of "eager" interpolation in
    neutron:
      logging.debug("foo %s" % arg)

    These should be converted to perform the interpolation lazily within
    the logging function, since if the severity is below the logging level
    then the interpolation can be skipped entirely.

    This change addresses all such current examples found in neutron core
    via a pylint test. Vendor plugins and services are fixed elsewhere.

    Change-Id: I823d8453cd76e4985cabd31ca6b939f43a80b36c
    Partial-Bug: #1404788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/143355
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=65dd2e510f48d4e5309fb550c9495be5b4bad253
Submitter: Jenkins
Branch: master

commit 65dd2e510f48d4e5309fb550c9495be5b4bad253
Author: Angus Lees <email address hidden>
Date: Mon Dec 22 15:38:40 2014 +1100

    bigswitch: Use lazy logging interpolation

    There are a small number of examples of "eager" interpolation in
    neutron:
      logging.debug("foo %s" % arg)

    These should be converted to perform the interpolation lazily within
    the logging function, since if the severity is below the logging level
    then the interpolation can be skipped entirely.

    This change addresses all such examples found in bigswitch via a pylint
    test. Other occurrences are addressed elsewhere.

    Change-Id: I23fd4e7d0e4173e753a124d62a1563ce6ac674ca
    Partial-Bug: #1404788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/143356
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=15581431c1a30a30f33860e0f895b7973d830e48
Submitter: Jenkins
Branch: master

commit 15581431c1a30a30f33860e0f895b7973d830e48
Author: Angus Lees <email address hidden>
Date: Mon Dec 22 15:40:03 2014 +1100

    embrane: Use lazy logging interpolation

    There are a small number of examples of "eager" interpolation in
    neutron:
      logging.debug("foo %s" % arg)

    These should be converted to perform the interpolation lazily within
    the logging function, since if the severity is below the logging level
    then the interpolation can be skipped entirely.

    This change addresses all such examples found in embrane via a pylint
    test. Other occurrences are addressed elsewhere.

    Change-Id: Iabceb8c7d32111ae97d1200fbd25681e317f7bb7
    Partial-Bug: #1404788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/143357
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4a5a8aab0f6a451642b459cdc510edb4e36a9858
Submitter: Jenkins
Branch: master

commit 4a5a8aab0f6a451642b459cdc510edb4e36a9858
Author: Angus Lees <email address hidden>
Date: Mon Dec 22 15:40:32 2014 +1100

    linuxbridge: Use lazy logging interpolation

    There are a small number of examples of "eager" interpolation in
    neutron:
      logging.debug("foo %s" % arg)

    These should be converted to perform the interpolation lazily within
    the logging function, since if the severity is below the logging level
    then the interpolation can be skipped entirely.

    This change addresses all such examples found in linuxbridge agent via a
    pylint test. Other occurrences are addressed elsewhere.

    Change-Id: I5cb3bbb401f5049760dfe5263a52bd43f23dcfd4
    Partial-Bug: #1404788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/143358
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a70a38fc8c23461a08ecadb113d2c54eb4e5bbc4
Submitter: Jenkins
Branch: master

commit a70a38fc8c23461a08ecadb113d2c54eb4e5bbc4
Author: Angus Lees <email address hidden>
Date: Mon Dec 22 15:41:01 2014 +1100

    brocade: Use lazy logging interpolation

    There are a small number of examples of "eager" interpolation in
    neutron:
      logging.debug("foo %s" % arg)

    These should be converted to perform the interpolation lazily within
    the logging function, since if the severity is below the logging level
    then the interpolation can be skipped entirely.

    This change addresses all such examples found in brocade
    l3_router_plugin via a pylint test. Other occurrences are addressed
    elsewhere.

    Change-Id: Ia2d51e8ecbc7af81390577ec69c5ce18523b65f3
    Partial-Bug: #1404788

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/143359
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ff03b268f78693c781c83aec575777381f5bcb95
Submitter: Jenkins
Branch: master

commit ff03b268f78693c781c83aec575777381f5bcb95
Author: Angus Lees <email address hidden>
Date: Mon Dec 22 15:41:28 2014 +1100

    ovs_dvr: Use lazy logging interpolation

    There are a small number of examples of "eager" interpolation in
    neutron:
      logging.debug("foo %s" % arg)

    These should be converted to perform the interpolation lazily within
    the logging function, since if the severity is below the logging level
    then the interpolation can be skipped entirely.

    This change addresses all such examples found in ovs agent via a pylint
    test. Other occurrences are addressed elsewhere.

    Change-Id: Ie215f33818cc5c16e570ace4c750df5371d27e09
    Partial-Bug: #1404788

[Armando Migliaccio (armando-migliaccio)]

This bug is > 172 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

[Launchpad Janitor (janitor)]

[Expired for neutron because there has been no activity for 60 days.]