iptables_manager is spamming neutron-full gate job log

[Brian Haley]

In this change:

commit 6eee93a98c67a5faf1d1243e0f8592c48d13bd6a
Author: Elena Ezhova <email address hidden>
Date: Fri Oct 31 19:37:46 2014 +0300

    Remove duplicate ensure_remove_chain method in iptables_manager

    Change-Id: I168eda2fa430446786d4106d6807207f4facbfc3
    Closes-Bug: #1388162

ensure_remove_chain() was removed since it seemed identical to remove_chain(). Unfortunately the neutron-full gate job is now spewing lots of warnings:

2014-12-18 19:43:37.909 2304 WARNING neutron.agent.linux.iptables_manager [req-a41864b2-9560-416f-86cb-d92d6748961a None] Attempted to remove chain sg-chain which does not exist
2014-12-18 19:43:37.909 2304 WARNING neutron.agent.linux.iptables_manager [req-a41864b2-9560-416f-86cb-d92d6748961a None] Attempted to remove chain sg-chain which does not exist
2014-12-18 19:45:51.950 2304 WARNING neutron.agent.linux.iptables_manager [req-a41864b2-9560-416f-86cb-d92d6748961a None] Attempted to remove chain s71604f53-6 which does not exist
2014-12-18 19:45:57.792 2304 WARNING neutron.agent.linux.iptables_manager [req-a41864b2-9560-416f-86cb-d92d6748961a None] Attempted to remove chain s71604f53-6 which does not exist
2014-12-18 19:46:12.923 2304 WARNING neutron.agent.linux.iptables_manager [req-a41864b2-9560-416f-86cb-d92d6748961a None] Attempted to remove chain s153151ab-c which does not exist
2014-12-18 19:46:12.923 2304 WARNING neutron.agent.linux.iptables_manager [req-a41864b2-9560-416f-86cb-d92d6748961a None] Attempted to remove chain s71604f53-6 which does not exist
...

For now we should revert this until we can track down what is causing the warning.

[Brian Haley (brian-haley)]

Aargh, now that FWaaS is split-out a revert is more difficult, putting the message under LOG.debug() will be good enough as a Step #1.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/142902

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/142902
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b63755abd905f7e01c6e7d65887e5e0c7c01a45c
Submitter: Jenkins
Branch: master

commit b63755abd905f7e01c6e7d65887e5e0c7c01a45c
Author: Brian Haley <email address hidden>
Date: Thu Dec 18 16:02:10 2014 -0500

    Don't log a warning if an iptables chain doesn't exist

    The iptables_manager remove_chain() function calls LOG.warn()
    if asked to remove a chain that it doesn't know about. This
    is spamming the neutron-full gate job pretty bad. Change to
    LOG.debug() since reverting the change that caused it is
    difficult since the FWaaS code has been split-out from the
    tree.

    Introduced in change 6eee93a98c67

    Change-Id: Ieb20ae01137223110abf3c933e4981ff39055398
    Closes-bug: #1404016