Typo in a unittest for allowed-address-pairs extension which may lead to false-positives
Bug #1400725 reported by
Roey Chen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
Undecided
|
Roey Chen |
Bug Description
The right alias for the security-group extension is 'security-group' and not 'security-groups',
with this typo, the if block will be skipped and in most of the time will cause the test to pass but not for the right reason.
Changed in neutron: | |
assignee: | nobody → Roey Chen (roeyc) |
status: | New → In Progress |
Changed in neutron: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/140341 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=7c18d1191c7 9fcfe46b60b6e5d 8f06a687c86688
Committed: https:/
Submitter: Jenkins
Branch: master
commit 7c18d1191c79fcf e46b60b6e5d8f06 a687c86688
Author: Roey Chen <email address hidden>
Date: Tue Dec 9 05:57:33 2014 -0800
Fixed test test_update_ port_security_ off_address_ pairs
This test checks that port-update fails with 409 return code when
port-security is turned off on a port which contains address-pairs.
The test had a typo ('security-groups' -> 'security-group') which would
have cause it to produce false-positive.
This change rewrites the test and eliminates the possibility of this
false-positive to occurs.
Change-Id: Ib54ad089872f28 eb28a3d4d050ba0 ee8fdc2bfe2
Closes-Bug: #1400725
Signed-off-by: Roey Chen <email address hidden>