FWaaS extension doesn't register its quota resources

[Ralf Haferkamp]

This issue is basically the same as https://bugs.launchpad.net/neutron/+bug/1305957 . Just for the FWaaS extension. In short FWaaS misses to pass the register_quota=True argument to build_resource_info().

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/139124

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/141064

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/141064
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=b823b339d5089dd3db329b7f89a431d7a3dc94d2
Submitter: Jenkins
Branch: master

commit b823b339d5089dd3db329b7f89a431d7a3dc94d2
Author: Ralf Haferkamp <email address hidden>
Date: Thu Dec 11 10:33:00 2014 +0100

    Adjust fwaas unit tests to work with quotas enabled

    To allow unit tests that create multiple firewalls succeeding even after
    bug#1399280 (FWaaS doesn't register it's quota resources) is fixed we
    create the firewalls in separate tenants.
    The default per-tenant quota for firewalls is "1". Additionally the
    plugin currently has a hardcoded limit of one firewall per tenant so
    there is no point in increasing the default quota.

    Change-Id: I7933d3bc6cf2465fe28604ea3dba9d38cf2e0a05
    Related-Bug: #1399280

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kyle Mestery (<email address hidden>) on branch: master
Review: https://review.openstack.org/139124
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/231246

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/231246
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=28948f6559711a0d861fa76f3adf65cda22768fb
Submitter: Jenkins
Branch: master

commit 28948f6559711a0d861fa76f3adf65cda22768fb
Author: German Eichberger <email address hidden>
Date: Mon Oct 5 15:50:52 2015 -0700

    Register FWaaS resources to quota engine

    This is picking up the work done in
    https://review.openstack.org/#/c/139124/5

    Increased some quotas to pass unit tests.

    Change-Id: I4e0e1810877b2fff3b097a143b8287a90acc0ff5
    Closes-Bug: #1399280

[Sean M. Collins (scollins)]

Was recently reverted. This work needs to be re-done, with a higher default quota.

[Manjeet Singh Bhatia (manjeet-s-bhatia)]

how much default quota is needed ?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/244281

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron-fwaas 8.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/284249

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/284249
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=e338df4244ca684d3b8a962341a6eab733f3e074
Submitter: Jenkins
Branch: master

commit e338df4244ca684d3b8a962341a6eab733f3e074
Author: James Arendt <email address hidden>
Date: Sat Feb 13 18:54:09 2016 -0800

    FWaaS quota registration

    Builds on prior attempts to register FWaaS resources to the quota
    engine, such as commit Ia4d6b9a65acd1111a050dc73b63a1f0ce619cb55
    which had to be reverted for bug 1513280 for failing gate via commit
    28948f6559711a0d861fa76f3adf65cda22768fb.

    Since with router insertion a user can have a separate firewall
    and policy per targeted router in their tenant, the original
    fixes which had defaults of only 1 were too low.

    Also added the release notes and updated the options to reflect
    the quota.

    Change-Id: I68a5538f7bc8df78212633c73eeca0eaae0d8455
    Closes-Bug: #1399280

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/285539

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron-fwaas 8.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/285539
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=2ce8b589c11d37d3f13ff37cf412d00f1e718e4b
Submitter: Jenkins
Branch: stable/liberty

commit 2ce8b589c11d37d3f13ff37cf412d00f1e718e4b
Author: James Arendt <email address hidden>
Date: Sat Feb 13 18:54:09 2016 -0800

    FWaaS quota registration

    Builds on prior attempts to register FWaaS resources to the quota
    engine, such as commit Ia4d6b9a65acd1111a050dc73b63a1f0ce619cb55
    which had to be reverted for bug 1513280 for failing gate via commit
    28948f6559711a0d861fa76f3adf65cda22768fb.

    Since with router insertion a user can have a separate firewall
    and policy per targeted router in their tenant, the original
    fixes which had defaults of only 1 were too low.

    Also added the release notes to reflect the quota.

    Set default as -1 (unlimited) in Liberty to avoid breaking
    compatibility.

    Change-Id: I68a5538f7bc8df78212633c73eeca0eaae0d8455
    Closes-Bug: #1399280

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron-fwaas 7.1.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Manjeet Singh Bhatia (<email address hidden>) on branch: master
Review: https://review.openstack.org/244281