no-op tests in test_dhcp_agent

Bug #1397184 reported by YAMAMOTO Takashi on 2014-11-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Low
YAMAMOTO Takashi

Bug Description

test_dhcp_agent uses assertCalledOnceWith, which is no-op.

Fix proposed to branch: master
Review: https://review.openstack.org/137719

Changed in neutron:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress
Changed in neutron:
importance: Undecided → Low

Reviewed: https://review.openstack.org/137719
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dd39a3eda370543119a5f69fd35d4f6a43f81c3f
Submitter: Jenkins
Branch: master

commit dd39a3eda370543119a5f69fd35d4f6a43f81c3f
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Nov 28 14:33:47 2014 +0900

    test_dhcp_agent: Fix no-op tests

    Fix some uses of assertCalledOnceWith, which seems like a mistake of
    assert_called_once_with.

    Also, add a hacking check to prevent the mistake.

    Closes-Bug: #1397184
    Change-Id: I12d077e2724d52eff65d55aff1130fbbb69671b1

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2014-12-18
Changed in neutron:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2015-04-30
Changed in neutron:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers