AttributeError on OVS agent startup with DVR on

[Armando Migliaccio]

aarrgh...

http://logs.openstack.org/48/136248/7/check/check-tempest-dsvm-neutron-dvr/3dc6138/logs/screen-q-agt.txt.gz?level=TRACE#_2014-11-21_17_55_44_254

[Armando Migliaccio (armando-migliaccio)]

This appears to be an innocuous trace introduced by:

https://review.openstack.org/#/c/123911/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/136529

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136529
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=aa728c00bab3bb6b3e00866e44ca054b1e848bb6
Submitter: Jenkins
Branch: master

commit aa728c00bab3bb6b3e00866e44ca054b1e848bb6
Author: armando-migliaccio <email address hidden>
Date: Fri Nov 21 14:41:05 2014 -0800

    Fix AttributeError during startup of ovs agent in DVR mode

    Make sure the agent starts processing incoming requests only after the entire
    initialization is complete. This is done by making explicit when the rpc loop
    is supposed to start, i.e. right at the end of the init process.

    This fix was necessary because the agent starts processing rpc messages even
    though it has not completed the entire initialization of bridges and data
    structures; this is usually okay, but in case of DVR, this leads to a
    situation where during the the first run, the agent asks the server to be
    assigned a MAC address; this in turn leads the server to fanout the generated
    MAC to the running agents, the requesting one included; because of the
    incomplete setup, the above mentioned error occurs. During subsequent
    restarts, the problem no longer appears.

    Closes-bug: #1395196

    Change-Id: I792697b94fef39971693cf8aff715c270601cecb

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/149686

[Zengfa Gao (zfgao)]

How ofter will this happen for Juno deployment?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/149686
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3332d4f1be47d5a679312d31377489ba0115e5a2
Submitter: Jenkins
Branch: stable/juno

commit 3332d4f1be47d5a679312d31377489ba0115e5a2
Author: armando-migliaccio <email address hidden>
Date: Fri Nov 21 14:41:05 2014 -0800

    Fix AttributeError during startup of ovs agent in DVR mode

    Make sure the agent starts processing incoming requests only after the entire
    initialization is complete. This is done by making explicit when the rpc loop
    is supposed to start, i.e. right at the end of the init process.

    This fix was necessary because the agent starts processing rpc messages even
    though it has not completed the entire initialization of bridges and data
    structures; this is usually okay, but in case of DVR, this leads to a
    situation where during the the first run, the agent asks the server to be
    assigned a MAC address; this in turn leads the server to fanout the generated
    MAC to the running agents, the requesting one included; because of the
    incomplete setup, the above mentioned error occurs. During subsequent
    restarts, the problem no longer appears.

    Closes-bug: #1395196

    Conflicts:
     neutron/plugins/openvswitch/agent/ovs_neutron_agent.py
    (cherry picked from commit aa728c00bab3bb6b3e00866e44ca054b1e848bb6)
    Change-Id: I792697b94fef39971693cf8aff715c270601cecb