neutron

bigswitch "test_server" prioritises inputs incorrectly

Bug #1386946 reported by Angus Lees
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Angus Lees
neutron 2015.1.0 "kilo"

Bug Description

neutron/plugins/bigswitch/tests/test_server.py incorrectly compares an int to a tuple during a binary search.

Apparently on python2, int < tuple is not an error and always True.

OpenStack Infra (hudson-openstack)
Changed in neutron:
assignee: nobody → Angus Lees (gus)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/117417
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=682f5a3effe544f0affabe384fcd3d4ee7d408f9
Submitter: Jenkins
Branch: master

commit 682f5a3effe544f0affabe384fcd3d4ee7d408f9
Author: Angus Lees <email address hidden>
Date: Thu Aug 28 14:39:52 2014 +1000

    Fix incorrect int/tuple comparison during binary search

    The code contains an incorrect int/tuple comparison during the binary
    search, which completely breaks the "priority" feature.
    (Apparently python2 thinks int < tuple is not an error and always True.)

    Change-Id: Ic404b38eabc87b105c7c2443b6177071b26d97ce
    Closes-Bug: #1386946

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.