ml2 extension manager doesn't pass db entry to entend_xxx_dict

Bug #1382448 reported by Isaku Yamahata
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
yalei wang

Bug Description

extension driver isn't passed dbentry to extension result dict
extend_{network, subnet, port}_dict() aren't passed db entry, but only result dict. In order to extend the result dict, db entry is necessary.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/129178

Changed in neutron:
assignee: nobody → Isaku Yamahata (yamahata)
status: New → In Progress
Revision history for this message
Isaku Yamahata (yamahata) wrote :

Supplement:

I hit this issue during I'm trying to convert portbindings extension into extension driver.
I'd like to reuse extend_port_dict_binding (or _extend_port_dict_binding_host).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Kyle Mestery (<email address hidden>) on branch: master
Review: https://review.openstack.org/129178
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in neutron:
assignee: Isaku Yamahata (yamahata) → Shweta P (shweta-ap05)
Changed in neutron:
assignee: Shweta P (shweta-ap05) → Isaku Yamahata (yamahata)
Changed in neutron:
assignee: Isaku Yamahata (yamahata) → Shweta P (shweta-ap05)
Changed in neutron:
assignee: Shweta P (shweta-ap05) → Isaku Yamahata (yamahata)
Changed in neutron:
assignee: Isaku Yamahata (yamahata) → Shweta P (shweta-ap05)
Changed in neutron:
assignee: Shweta P (shweta-ap05) → yalei wang (yalei-wang)
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → kilo-3
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/152759
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c027c6cef8145b666e5622a3a2796d4a2d67af7a
Submitter: Jenkins
Branch: master

commit c027c6cef8145b666e5622a3a2796d4a2d67af7a
Author: Shweta P <email address hidden>
Date: Tue Feb 3 20:23:31 2015 -0500

    Passes the plugin context variable in the ML2 Extension Driver API

    Many neutron extensions(like portsecurity) use the plugin_context
    variable instead of just the database session. This change
    modifies the extension driver api to pass the plugin_context

    Change request also modifies the extend_XXX resource api to use the
    respective data model(network/subnet/port) passed to it.

    Implements: blueprint extensions-in-ml2
    Partially Implements: blueprint ml2-ovs-portsecurity
    Closes-Bug: 1382448
    Change-Id: Icf84615e5fee8b59cbc95ab9b634f1a49f4b56a3

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.