_get_security_groups_on_port tries to get [0] on a set type

[Jacek Świderski]

_get_security_groups_on_port checks before that all security groups on port belong to tenant - and if there are any that don't fulfill this requirement it tries to raise SecurityGroupNotFound but fails with :
TypeError: 'set' object does not support indexing

        port_sg_missing = requested_groups - valid_groups
        if port_sg_missing:
            raise ext_sg.SecurityGroupNotFound(id=str(port_sg_missing[0]))

One thing is the fail itself - but beside I think that message = _("Security group %(id)s does not exist"), where id would be a randomly chosen missing id isn't really clear in this context and new exception should be created for this case.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/124070

[OpenStack Infra (hudson-openstack)]

Change abandoned by Salvatore Orlando (<email address hidden>) on branch: master
Review: https://review.openstack.org/124070
Reason: This patch has been inactive long enough that I think it's safe to abandon.
The author can resurrect it if needed.

[watanabe.isao (watanabe.isao)]

Hello, Jacek Świderski.
Our team hit this bug in our test, too.
We would like to see this bug fixed in kilo, best as your idea.
Are your still working on this issue?
If not, may I continue with your work in this bug report and in the gerrit brunch[1]?

[1]https://review.openstack.org/#/c/124070/

[Jacek Świderski (jacek-swiderski)]

Hello, Isao.
Feel free to take over my change I'm not currently working on OpenStack - I've restored it on gerrit for you.

Jacek

[watanabe.isao (watanabe.isao)]

Hello, Jacek Świderski.
Thank you for your help. (^^)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/152373

[OpenStack Infra (hudson-openstack)]

Change abandoned by watanabe isao (<email address hidden>) on branch: master
Review: https://review.openstack.org/152373

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/124070
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d907762f3cca1405eedaaad5d5841491576c8c54
Submitter: Jenkins
Branch: master

commit d907762f3cca1405eedaaad5d5841491576c8c54
Author: Kevin Benton <email address hidden>
Date: Fri Mar 27 23:18:08 2015 -0700

    Fix error raising in security groups method

    In case there were security groups not belonging to tenant on port
    _get_security_groups_on_port would try to raise exception but fail
    trying to index set.

    This patch simply joins the whole set as a string and inserts it
    into the standard SecurityGroupNotFound exception.

    No new exception types, no string freeze violations.

    Co-Author: watanabe.isao <email address hidden>
    Co-Author: Jacek Swiderski <email address hidden>

    Change-Id: I039ea57269dc53ced8dece0985f33ce9ae7eab17
    Closes-Bug: #1373816

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072