AttributeError while accessing vif_type during port binding

[Armando Migliaccio]

This error has been observed frequently in the last few days:

 AttributeError: 'NoneType' object has no attribute 'vif_type'

This happens on a variety of Jenkins jobs, more particularly with the -pg and -dvr jobs.

The logstash query:

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiQXR0cmlidXRlRXJyb3I6ICdOb25lVHlwZScgb2JqZWN0IGhhcyBubyBhdHRyaWJ1dGUgJ3ZpZl90eXBlXCIgQU5EIGZpbGVuYW1lOlwibG9ncy9zY3JlZW4tcS1zdmMudHh0XCIiLCJmaWVsZHMiOltdLCJvZmZzZXQiOjAsInRpbWVmcmFtZSI6IjYwNDgwMCIsImdyYXBobW9kZSI6ImNvdW50IiwidGltZSI6eyJ1c2VyX2ludGVydmFsIjowfSwic3RhbXAiOjE0MTA5NjY3ODI1ODl9

Reveals that this log trace does not necessarily lead to a test failure but ultimately it would be good to get rid of this.

[Eugene Nikanorov (enikanorov)]

According to the logs, it happens when dhcp port details are requested by the agent, but at the same time the port is concurrently deleted during network deletion

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/124650

[Armando Migliaccio (armando-migliaccio)]

This happens for DVR interfaces too:

http://logs.openstack.org/17/127017/4/check/check-tempest-dsvm-neutron-dvr/581108f/logs/screen-q-svc.txt.gz?level=TRACE#_2014-10-08_22_07_30_377

So I am not sure your proposed patch fixes all the potential failure modes.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/124650
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=36b7ceb050a6805d30cbac4562e109dddf3cba25
Submitter: Jenkins
Branch: master

commit 36b7ceb050a6805d30cbac4562e109dddf3cba25
Author: Eugene Nikanorov <email address hidden>
Date: Mon Sep 29 01:02:58 2014 +0400

    Check for concurrent port binding deletion before binding the port

    When agent tries to update port binding (DVR or regular), the port
    might have already been deleted via API call.
    This is not an error condition but should be handled to avoid traces
    in the logs.

    Change-Id: Ie9436172151f0ecd5b3e4667328910b09f8ef141
    Closes-Bug: #1370570