Fix execution on udevadm program inside neutron agents

Bug #1367697 reported by Daniele Rondina
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Carol Bouchard

Bug Description

Hi,

inside file ovs_neutron_agent.py and ofa_neutron_agent.py there is an absolute path on call udevadm program.

In this case an absolute path is not the best solution because on different distro path could be different. For example on gentoo distro udevadm path is /usr/bin/udevadm.

About this there are two solutions:

a) use directly name of the program without absolute path , so in this case only "udevadm" (Eventually add note that this program must be present on PATH of the neutron agent/daemon.

b) manage a variable like root_helper , for example udevadm_helper to permit configuration of the path from configuration file.

Probably solution a could be sufficient in this case.

Thanks
Geaaru

Tags: ovs ofa
Changed in neutron:
importance: Undecided → Low
tags: added: ofa ovs
Changed in neutron:
assignee: nobody → Carol Bouchard (caboucha)
Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/127654

Revision history for this message
Carol Bouchard (caboucha) wrote :

recheck mlnx

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/127654
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6eaed7f7244bde260fc21c1d29b2e7da74c9c67b
Submitter: Jenkins
Branch: master

commit 6eaed7f7244bde260fc21c1d29b2e7da74c9c67b
Author: Carol Bouchard <email address hidden>
Date: Fri Oct 10 17:06:04 2014 -0400

    Execute udevadm on other linux installs

    When ofa and ovs neutron agents start, they use the linux utility
    'udevadm'. It is passed as an argument with an absolute directory path
    which can vary on each linux install. By removing the directory path,
    it will find this utility by way of the user's environment path since
    linux executables are configured in each user's path upon user creation.

    Change-Id: I2344290d38c7889b8f32d8fb9c5161b09826e037
    Closes-bug: #1367697

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers