TAP_PREFIX_LEN constant is defined several times

[Rossella Sblendido]

TAP_PREFIX_LEN constant is defined several times, it should be defined only once preferably in neutron/common/constants.py .

From a coarse grep:

grep -r "TAP" . | grep 3

./neutron/plugins/brocade/NeutronPlugin.py: TAP_PREFIX_LEN = 3
./neutron/plugins/linuxbridge/lb_neutron_plugin.py: TAP_PREFIX_LEN = 3
./neutron/plugins/ml2/rpc.py:TAP_DEVICE_PREFIX_LENGTH = 3
./neutron/plugins/mlnx/rpc_callbacks.py: TAP_PREFIX_LEN = 3

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/116970

[Mark McClain (markmcclain)]

Different technologies may not always share the same device naming standards or length. They just all happen to be same right now.

[Rossella Sblendido (rossella-o)]

Right. If a technology uses a different naming standard a new constant can be defined. For the same naming standard I think it's cleaner to use the same constant

[Sam Betts (sambetts)]

I agree. These constants are used for exactly the same reason in every use case, if the vendors decide to change the way their implementation works they can add a new constant, but for consistency these shared values should be collated somewhere.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/116970
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5e4c14e850e2757bf74a806aaaab4c053bab741d
Submitter: Jenkins
Branch: master

commit 5e4c14e850e2757bf74a806aaaab4c053bab741d
Author: Sam Betts <email address hidden>
Date: Tue Aug 26 18:35:36 2014 +0100

    Added TAP_DEVICE_PREFIX info to common/constants

    Change-Id: Ia84629732490585164237ca4f7d1db90bde9fbf2
    Closes-Bug: 1361573

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: feature/lbaasv2
Review: https://review.openstack.org/130864

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/130864
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c089154a94e5872efc95eab33d3d0c9de8619fe4
Submitter: Jenkins
Branch: feature/lbaasv2

commit 62588957fbeccfb4f80eaa72bef2b86b6f08dcf8
Author: Kevin Benton <email address hidden>
Date: Wed Oct 22 13:04:03 2014 -0700

    Big Switch: Switch to TLSv1 in server manager

    Switch to TLSv1 for the connections to the backend
    controllers. The default SSLv3 is no longer considered
    secure.

    TLSv1 was chosen over .1 or .2 because the .1 and .2 weren't
    added until python 2.7.9 so TLSv1 is the only compatible option
    for py26.

    Closes-Bug: #1384487
    Change-Id: I68bd72fc4d90a102003d9ce48c47a4a6a3dd6e03

commit 17204e8f02fdad046dabdb8b31397289d72c877b
Author: OpenStack Proposal Bot <email address hidden>
Date: Wed Oct 22 06:20:15 2014 +0000

    Imported Translations from Transifex

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I58db0476c810aa901463b07c42182eef0adb5114

commit d712663b99520e6d26269b0ca193527603178742
Author: Carl Baldwin <email address hidden>
Date: Mon Oct 20 21:48:42 2014 +0000

    Move disabling of metadata and ipv6_ra to _destroy_router_namespace

    I noticed that disable_ipv6_ra is called from the wrong place and that
    in some cases it was called with a bogus router_id because the code
    made an incorrect assumption about the context. In other case, it was
    never called because _destroy_router_namespace was being called
    directly. This patch moves the disabling of metadata and ipv6_ra in
    to _destroy_router_namespace to ensure they get called correctly and
    avoid duplication.

    Change-Id: Ia76a5ff4200df072b60481f2ee49286b78ece6c4
    Closes-Bug: #1383495

commit f82a5117f6f484a649eadff4b0e6be9a5a4d18bb
Author: OpenStack Proposal Bot <email address hidden>
Date: Tue Oct 21 12:11:19 2014 +0000

    Updated from global requirements

    Change-Id: Idcbd730f5c781d21ea75e7bfb15959c8f517980f

commit be6bd82d43fbcb8d1512d8eb5b7a106332364c31
Author: Angus Lees <email address hidden>
Date: Mon Aug 25 12:14:29 2014 +1000

    Remove duplicate import of constants module

    .. and enable corresponding pylint check now the only offending instance
    is fixed.

    Change-Id: I35a12ace46c872446b8c87d0aacce45e94d71bae

commit 9902400039018d77aa3034147cfb24ca4b2353f6
Author: rajeev <email address hidden>
Date: Mon Oct 13 16:25:36 2014 -0400

    Fix race condition on processing DVR floating IPs

    Fip namespace and agent gateway port can be shared by multiple dvr routers.
    This change uses a set as the control variable for these shared resources
    and ensures that Test and Set operation on the control variable are
    performed atomically so that race conditions do not occur among
    multiple threads processing floating IPs.
    Limitation: The scope of this change is limited to addressing the race
    condition described in the bug report. It may not address other issues
    such as pre-existing issue wit...