neutron metering driver default value is different in code and config file

Bug #1360958 reported by Liping Mao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Liping Mao

Bug Description

We have the following config in etc/metering_agent.ini:
# driver = neutron.services.metering.drivers.iptables.iptables_driver.IptablesMeteringDriver

But in code, the default value of the driver in metering_agent.py is:
        cfg.StrOpt('driver',
                   default='neutron.services.metering.drivers.noop.'
                   'noop_driver.NoopMeteringDriver',

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/116536

Changed in neutron:
assignee: nobody → Liping Mao (limao)
status: New → In Progress
Revision history for this message
Wei Wang (damon-devops) wrote :

Nice catch

Kyle Mestery (mestery)
Changed in neutron:
milestone: none → juno-3
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/116536
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d8deab298d59c0c67d634973e298d180f37ef0f2
Submitter: Jenkins
Branch: master

commit d8deab298d59c0c67d634973e298d180f37ef0f2
Author: Liping Mao <email address hidden>
Date: Mon Aug 25 09:03:24 2014 +0800

    metering driver default value is different in code and config file

    We defined the metering driver is IptablesMeteringDriver in config,
    but in code, the driver is NoopMeteringDriver.

    Change-Id: Ia4fb6751e8a9919f844ef27a303e2fa95b46670e
    Closes-Bug: #1360958

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.