validator shouldn't raise exception

[Wei Wang]

In the function neutron.extension.allowedaddresspairs._validate_allowed_address_pairs, validator raises exception instead of return message which other validators do.

[Eugene Nikanorov (enikanorov)]

It's not clear which way is preferable even though other validators just return messages

For instance, block

 if len(address_pairs) > cfg.CONF.max_allowed_address_pair:
        raise AllowedAddressPairExhausted(
            quota=cfg.CONF.max_allowed_address_pair)

raising an exception not typically raised from API/request validation layer, so raising it here seems to be appropriate.

[Liping Mao (limao)]

Not only in allowedaddresspairs, but also in the following extensions:
extra_dhcp_opt
extraroute
multiprovidernet
providernet
securitygroup

But I think raise the message here is also OK.

[Cedric Brandily (cbrandily)]

This bug is > 365 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

[Launchpad Janitor (janitor)]

[Expired for neutron because there has been no activity for 60 days.]