Neutron creates oslo.messaging.Server object directly
Bug #1357236 reported by
Alexei Kornienko
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
Wishlist
|
Mark McClain |
Bug Description
oslo.messaging provides a factory method to create a Server object. It should be used to create it. Additionaly Neutron uses custom RPCDispatcher to log incoming messages. This duplicates existing functionality in oslo.messaging.
Changed in neutron: | |
assignee: | nobody → Alexei Kornienko (alexei-kornienko) |
status: | New → In Progress |
Changed in neutron: | |
assignee: | Alexei Kornienko (alexei-kornienko) → Oleg Bondarev (obondarev) |
Changed in neutron: | |
importance: | Undecided → Wishlist |
Changed in neutron: | |
assignee: | Oleg Bondarev (obondarev) → Eugene Nikanorov (enikanorov) |
Changed in neutron: | |
assignee: | Eugene Nikanorov (enikanorov) → Mark McClain (markmcclain) |
Changed in neutron: | |
milestone: | none → juno-rc1 |
Changed in neutron: | |
status: | Fix Committed → Fix Released |
Changed in neutron: | |
milestone: | juno-rc1 → 2014.2 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/111056 /git.openstack. org/cgit/ openstack/ neutron/ commit/ ?id=185f09b7c46 edcbb1d39d3b799 93fa8c07dafc2c
Committed: https:/
Submitter: Jenkins
Branch: master
commit 185f09b7c46edcb b1d39d3b79993fa 8c07dafc2c
Author: Alexei Kornienko <email address hidden>
Date: Thu Jul 31 22:08:54 2014 +0300
Removed direct access to MessagingServer
Factory method provided by the library should be used to create a server
object. This allows to change servers internal implementation without
touching end users.
Also removed custom dispatcher. Its only purpose was to log messages. _drivers/ amqpdriver. py [1]
If logging is configured accordingly all incoming messages will be
logged from oslo/messaging/
[1] http:// goo.gl/ nV9tcu
Closes-Bug: #1357236
Change-Id: Ic208994c5a64fd 48528cb41d30a97 5d68d84af05