Syntax error in plugins/vmware/plugins/service.py

[Angus Lees]

plugins.vmware.plugins.service.NsxAdvancedPlugin contains this code:

    def _create_lrouter(self, context, router, nexthop):
        ...
        lswitch = self._create_integration_lswitch(
                tenant_id, lsname)
       ...
       except Exception:
                   ...
                   self.vcns_driver.delete_lswitch(lswitch('uuid')) # <--- should be lswitch['uuid']

The result from _create_integration_lswitch is a json (dict) object, not a callable. That last line should use lswitch['uuid']

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/143576

[OpenStack Infra (hudson-openstack)]

Change abandoned by Angus Lees (<email address hidden>) on branch: master
Review: https://review.openstack.org/113777

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/143576
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=73c9a5fc7c0ed9758af28e7061428544b2475af0
Submitter: Jenkins
Branch: master

commit 73c9a5fc7c0ed9758af28e7061428544b2475af0
Author: Angus Lees <email address hidden>
Date: Tue Dec 23 11:13:27 2014 +1100

    Enable the "not-callable" pylint check

    This check catches attempts to call variables that pylint believes are
    not functions. A trivial example would be:

        # Trivial example caught by this check:
        foo = dict()
        print foo('bar') # <- oops, meant foo['bar']

    This change enables the "not-callable" pylint check, after disabling a
    few cases where the alert triggers but the usage was intended (defining
    decorators).

    Change-Id: I09ad929902509018fe7183a15b784601c36b6196
    Related-Bug: #1356224

[Armando Migliaccio (armando-migliaccio)]

This bug is > 172 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

[Launchpad Janitor (janitor)]

[Expired for neutron because there has been no activity for 60 days.]