when a interface is added after router gateway set,external connectivity using snat fails

[Preethi Dsilva]

1.create n/w,subnet
2.create a dvr and attach the subnet
3/create external network and attach the router gateway
4.now boot a vm in that subnet
5.ping to external network -successful
6.create a new network,subnet attach it to router created in step 2.
7.boot a vm and ping to external network -fails
8.try to ping to external network using vm created in step 4 -fails

Reason:
=======
when new subnet is added ,all the sg ports inside snat namespace are updated with default gateway of subnet added
say i had subnet 4.4.4.0/24 already attached to router its sg port had ip 4.4.4.2,now when i add new subnet say 5.5.5.0/24 this router
sg port of 4.4.4.0/24 becomes 5.5.5.1 also sg ip of 5.5.5.0/24 also becomes 5.5.5.1 (even though 5.5.5.1 has device owner =network:router_interface_distributed and 5.5.5.2 has device owner as network:router_centralized_snat)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/113412

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/113412
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=11ca12dd8752a7d8fc13027c21ee572233becb74
Submitter: Jenkins
Branch: master

commit 11ca12dd8752a7d8fc13027c21ee572233becb74
Author: rajeev <email address hidden>
Date: Mon Aug 11 20:42:18 2014 -0400

    Fix interface add for dvr with gateway

    when an interface is added after router gateway set, external
    connectivity using snat fails. Instead of just adding the snat port for
    the new subnet, method internal_network_added(..) incorrectly re-adds
    all the snat ports with wrong cidr.

    Change-Id: I7bfe266288670fba0c90990bf350f43ef7829bad
    Closes-bug: #1355087

[Rajeev Grover (rajeev-grover)]

The previous fix addresses the issue of existing interfaces being updated with wrong IP addresses on addition of a new interface. The IP address of the newly added interface is still showing up incorrect. Additional fix is needed for the same.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/118378

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/118378
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=300b2a6ae136eae7e7313ff8e7d94110e08b131a
Submitter: Jenkins
Branch: master

commit 300b2a6ae136eae7e7313ff8e7d94110e08b131a
Author: rajeev <email address hidden>
Date: Tue Sep 2 11:06:25 2014 -0400

    Fix interface IP address for DVR with gateway

    when an interface is added to a router with gateway, the method
    internal_network_added(..) incorrectly configures the IP address
    of the new snat interface same as the IP address of the new
    subnet interface.

    Change-Id: I00d4ff1105a443b89b28359249b8e83fb4c1d157
    Closes-bug: #1355087