Migration of legacy router to distributed router not working

[Carl Baldwin]

This was a know backlog item when DVR code merged.

[Swaminathan Vasudevan (swaminathan-vasudevan)]

Will work on the router migration/convertion.

[Carl Baldwin (carl-baldwin)]

https://review.openstack.org/#/c/105855/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/118491

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/119253

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/123273

[Kyle Mestery (mestery)]

Removing from Juno-RC. We'll have to back port these to the first Juno stable release once they land in Kilo.

[Armando Migliaccio (armando-migliaccio)]

Yes, to fix this we have three fairly beefy patches, which require some work still.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/105855
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f005dd5c9b982eca03722a7b2684eeb42a83be2b
Submitter: Jenkins
Branch: master

commit f005dd5c9b982eca03722a7b2684eeb42a83be2b
Author: Swaminathan Vasudevan <email address hidden>
Date: Tue Aug 5 16:16:23 2014 -0700

    Implement migration of legacy routers to distributed

    This patch addresses the necessary changes required
    for the router migration or conversion from legacy
    to distributed.

    The _update_router_db() method was modified to add
    logic to support the SNAT functionality of DVR by
    calling create_snat_intf_ports_if_not_exists(). A
    call to _unbind_router() was also called to force
    the scheduling of the router with 'distributed'
    enabled.

    Right now we will be supporting migration from legacy
    to distributed only.

    Closes-bug: #1348309
    Partially-implements: blueprint neutron-ovs-dvr
    Co-Authored-By: Michael Smith <email address hidden>
    Change-Id: I6f252271bb5b52ce57184ad7b0bf1ce280b965fb

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Smith (<email address hidden>) on branch: master
Review: https://review.openstack.org/119253
Reason: not needed for migration

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/123273
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c41f4a397dc32efa39a0fcce2131caa46692cb03
Submitter: Jenkins
Branch: master

commit c41f4a397dc32efa39a0fcce2131caa46692cb03
Author: Swaminathan Vasudevan <email address hidden>
Date: Fri Sep 19 10:41:09 2014 -0700

    Validate legacy router services before migration

    When legacy routers are migrated to distributed
    routers, we need to make sure that there are no
    Advanced services associated with the router.

    If Advanced services such as FWaaS or VPNaaS is
    associated with the router, we raise an exception
    and stop the migration.

    Partial-bug: #1348309

    DocImpact

    Change-Id: I65909040a16b022108e481344064d375050d731c