Table tz_network_bindings uses nullable on primary keys

Bug #1346900 reported by Jakub Libosvar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Jakub Libosvar

Bug Description

Primary key cannot be null therefore setting NULL on column that is primary key is wrong and then generates wrong migration script using autogenerate.

Tags: vmware
Changed in neutron:
assignee: nobody → Jakub Libosvar (libosvar)
summary: - Tables tz_network_bindings and tz_network_bindings use nullable use
- nullable on primary keys
+ Table tz_network_bindings uses nullable on primary keys
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/108690

Changed in neutron:
status: New → In Progress
Akihiro Motoki (amotoki)
tags: added: vmware
Changed in neutron:
importance: Undecided → Low
Revision history for this message
Henry Gessau (gessau) wrote :

This bug should have the same milestone and importance as bug 1346638 (juno-3, medium).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/108690
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e416a5420f45391c180f84098f4d2c02ecf857b9
Submitter: Jenkins
Branch: master

commit e416a5420f45391c180f84098f4d2c02ecf857b9
Author: Jakub Libosvar <email address hidden>
Date: Tue Jul 22 15:22:24 2014 +0200

    Replace nullable from primary keys in tz_network_bindings with default

    Columns vlan_id and phy_uuid were both nullable and primary keys.
    Primary keys cannot be nulls. This situation caused problems in
    autogenerating scripts creating always migration that set these columns
    to nullable.

    Instead of having primary keys nullable this patch creates a default
    values.

    Change-Id: I04642f6d6ad232997a593bff8ca44f9a7a803ffd
    Closes-bug: #1346900

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.