Help text for neutron router-create lists 'distributed' as a positional argument

[Assaf Muller]

With the following patch merged:
https://review.openstack.org/#/c/106147/

neutron router-create -h
usage: neutron router-create [-h] [-f {shell,table,value}] [-c COLUMN]
                             [--variable VARIABLE] [--prefix PREFIX]
                             [--request-format {json,xml}]
                             [--tenant-id TENANT_ID] [--admin-state-down]
                             NAME

Create a router for a given tenant.

positional arguments:
  NAME Name of router to create.
  distributed Create a distributed router.

The distributed flag doesn't appear in the usage block, but appears as a positional argument when it is not.

neutron router-create r1 distributed doesn't work, while neutron router-create r1 --distributed does.

To summarize:
distributed shouldn't appear in the positional arguments list, but should instead appear in the usage block.

[Assaf Muller (amuller)]

The fix has been reverted. There's a new patch/bug around this subject:
https://bugs.launchpad.net/neutron/+bug/1347960

[Swaminathan Vasudevan (swaminathan-vasudevan)]

Yes as Assaf mentioned above, this is the patch that address both of our concerns.

https://review.openstack.org/#/c/109180/

But we need to check with the VMware plugin folks on this fix, if it would affect them.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/114263

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/114263
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=deb850b7282995d7e3b31210c177a2661578765b
Submitter: Jenkins
Branch: master

commit deb850b7282995d7e3b31210c177a2661578765b
Author: Assaf Muller <email address hidden>
Date: Mon Jul 21 16:37:23 2014 +0300

    Fix CLI support for DVR, take 2

    Previously --distributed was displayed as positional
    argument in the help text, but acted as an optional
    argument with the -- semantics. It now behaves like
    any other optional argument.

    A side-effect is that previously you could:
    1) neutron router-create --distributed r1
    2) neutron router-create --distributed=True r1
    3) neutron router-create --distributed=False r1

    While now only options 2 and 3 are viable.

    DocImpact
    Partially-implements: blueprint neutron-ovs-dvr
    Closes-Bug: #1346121
    Change-Id: I60675b4f60fe8154af4ab6d8f0e93867cf362a59