Bug #1339855 “Raise NotImplementedError instead of NotImplemente...” : Bugs : neutron

OpenStack Infra (hudson-openstack) on 2014-07-09

Changed in neutron:
assignee:	nobody → Christian Berendt (berendt)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-09: Fix proposed to fuel-web (master)

#1

Fix proposed to branch: master
Review: https://review.openstack.org/105858

Changed in fuel:
assignee:	nobody → Christian Berendt (berendt)
status:	New → In Progress

Nastya Urlapova (aurlapova) on 2014-07-09

Changed in fuel:
importance:	Undecided → Medium
milestone:	none → 5.1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-10: Fix merged to cloudcafe (master)

#2

Reviewed: https://review.openstack.org/105859
Committed: https://git.openstack.org/cgit/stackforge/cloudcafe/commit/?id=dfe834bb9bbb394ad771d2f89f63179c534bf7a5
Submitter: Jenkins
Branch: master

commit dfe834bb9bbb394ad771d2f89f63179c534bf7a5
Author: Christian Berendt <email address hidden>
Date: Wed Jul 9 21:58:34 2014 +0200

Raise NotImplementedError instead of NotImplemented

NotImplementedError is the name of the exception
(https://docs.python.org/2/library/exceptions.html).

NotImplemented is the name of a constant
(https://docs.python.org/2/library/constants.html).

It makes no sense to raise a constant. The exception should
be raised instead.

Change-Id: I369b47dac60106f96aed9d044f8b510afd09d266
Closes-Bug: #1339855

Changed in cloudcafe:
status:	New → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-21: Fix merged to fuel-web (master)

#3

Reviewed: https://review.openstack.org/105858
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=9376d43da8781cade8eb96a2d51e1c49dcc4c863
Submitter: Jenkins
Branch: master

commit 9376d43da8781cade8eb96a2d51e1c49dcc4c863
Author: Christian Berendt <email address hidden>
Date: Wed Jul 9 21:56:22 2014 +0200

Raise NotImplementedError instead of NotImplemented

NotImplementedError is the name of the exception
(https://docs.python.org/2/library/exceptions.html).

NotImplemented is the name of a constant
(https://docs.python.org/2/library/constants.html).

It makes no sense to raise a constant. The exception should
be raised instead.

Change-Id: I47efa6db2484757022d5f0601719d4ea4c78417d
Closes-Bug: #1339855

Changed in fuel:
status:	In Progress → Fix Committed

Mark McClain (markmcclain) on 2014-08-27

tags:

added: icehouse-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-08-28: Fix merged to neutron (master)

#4

Reviewed: https://review.openstack.org/104869
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e8e2392321e0fd3e2b8a0345b725f2e8df854a34
Submitter: Jenkins
Branch: master

commit e8e2392321e0fd3e2b8a0345b725f2e8df854a34
Author: Christian Berendt <email address hidden>
Date: Fri Jul 4 13:12:26 2014 +0200

Raise NotImplementedError instead of NotImplemented

NotImplementedError is the name of the exception
(https://docs.python.org/2/library/exceptions.html).

NotImplemented is the name of a constant
(https://docs.python.org/2/library/constants.html).

It makes no sense to raise a constant. The exception should
be raised instead.

Change-Id: I4969e26eb7b46f008ea3c8bd0093490c425f7069
Closes-Bug: #1339855

Changed in neutron:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2014-09-04

Changed in neutron:
milestone:	none → juno-3
status:	Fix Committed → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-09-09: Change abandoned on warm (master)

#5

Change abandoned by Romain Hardouin (<email address hidden>) on branch: master
Review: https://review.openstack.org/120044
Reason: Already fixed by Christian Berendt: https://review.openstack.org/#/c/104872/

Thierry Carrez (ttx) on 2014-10-16

Changed in neutron:
milestone:	juno-3 → 2014.2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-09:

#6

Change abandoned by Christian Berendt (<email address hidden>) on branch: master
Review: https://review.openstack.org/104872
Reason: out of date

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-03: Fix proposed to python-fuelclient (master)

#7

Fix proposed to branch: master
Review: https://review.openstack.org/365189

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-03:

#8

Fix proposed to branch: master
Review: https://review.openstack.org/365193

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-04: Change abandoned on python-fuelclient (master)

#9

Change abandoned by JiWei (<email address hidden>) on branch: master
Review: https://review.openstack.org/365189
Reason: 重复

Dave Chen (wei-d-chen) on 2016-09-05

Changed in keystone:
importance:	Undecided → Medium
assignee:	nobody → Ji.Wei (jiwei)

Ji.Wei (jiwei) on 2016-09-05

Changed in warm:
assignee:	nobody → Ji.Wei (jiwei)

Revision history for this message

Ji.Wei (jiwei) wrote on 2016-09-05:

#10

@Dave Chen

hi Dave Chen , I didn't find this component. ：）

Changed in warm:
status:	New → Invalid

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-05: Fix merged to keystone (master)

#11

Reviewed: https://review.openstack.org/365196
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=5a49379b349dc33f403cfdcfd6148dfa362512de
Submitter: Jenkins
Branch: master

commit 5a49379b349dc33f403cfdcfd6148dfa362512de
Author: Ji-Wei <email address hidden>
Date: Sat Sep 3 13:03:13 2016 +0800

Raise NotImplementedError instead of NotImplemented

    NotImplementedError is the name of the exception
    (https://docs.python.org/2/library/exceptions.html).
    NotImplemented is the name of a constant
    (https://docs.python.org/2/library/constants.html).
    >>> raise NotImplemented()
    Traceback (most recent call last):
      File "<pyshell#31>", line 1, in <module>
        raise NotImplemented()
    TypeError: 'NotImplementedType' object is not callable
    >>> raise NotImplementedError()
    Traceback (most recent call last):
      File "<pyshell#32>", line 1, in <module>
        raise NotImplementedError()
    NotImplementedError

This patch fix it.

Change-Id: I36292e5ee18bd792205a8ff527f4ae9705c61b61
Closes-Bug: #1339855

Changed in keystone:
status:	New → Fix Released

Ji.Wei (jiwei) on 2016-09-06

Changed in solar:
assignee:	nobody → Ji.Wei (jiwei)
Changed in keystonemiddleware:
assignee:	nobody → Ji.Wei (jiwei)
status:	New → In Progress
Changed in solar:
status:	New → In Progress

Steve Martinelli (stevemar) on 2016-09-15

Changed in keystone:
milestone:	none → newton-rc1

Ji.Wei (jiwei) on 2016-09-18

Changed in heat:
assignee:	nobody → Ji.Wei (jiwei)

OpenStack Infra (hudson-openstack) on 2016-09-18

Changed in heat:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-20: Fix merged to heat (master)

#12

Reviewed: https://review.openstack.org/367735
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=2a662465361e31dbf230d597182f9f7fd8b61183
Submitter: Jenkins
Branch: master

commit 2a662465361e31dbf230d597182f9f7fd8b61183
Author: Ji-Wei <email address hidden>
Date: Fri Sep 9 13:06:26 2016 +0800

Raise NotImplementedError instead of NotImplemented

    NotImplementedError is the name of the exception
    (https://docs.python.org/2/library/exceptions.html).
    NotImplemented is the name of a constant
    (https://docs.python.org/2/library/constants.html).
    >>> raise NotImplemented()
    Traceback (most recent call last):
      File "<pyshell#0>", line 1, in <module>
        raise NotImplemented()
    TypeError: 'NotImplementedType' object is not callable
    >>> raise NotImplementedError()
    Traceback (most recent call last):
      File "<pyshell#1>", line 1, in <module>
        raise NotImplementedError()
    NotImplementedError
    This patch fix it.

Change-Id: I939eaa4b4b7c574f7a6447725e3a6ad5b128f1b7
Closes-Bug: #1339855

Changed in heat:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-09-26

Changed in keystonemiddleware:
assignee:	Ji.Wei (jiwei) → Jamie Lennox (jamielennox)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-26: Fix merged to keystonemiddleware (master)

#13

Reviewed: https://review.openstack.org/365509
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=f2792d7d07adb18a9fe676f28e589ebac6ed61a1
Submitter: Jenkins
Branch: master

commit f2792d7d07adb18a9fe676f28e589ebac6ed61a1
Author: Ji-Wei <email address hidden>
Date: Mon Sep 5 18:10:12 2016 +0800

Raise NotImplementedError instead of NotImplemented

    NotImplementedError is the name of the exception
    (https://docs.python.org/2/library/exceptions.html).
    NotImplemented is the name of a constant
    (https://docs.python.org/2/library/constants.html).
    This patch fix it.

Change-Id: If0c220b8fc8480e5904400e9086935944bce728a
Closes-Bug: #1339855

Changed in keystonemiddleware:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-26: Fix included in openstack/cinder 9.0.0.0rc1

#14

This issue was fixed in the openstack/cinder 9.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-26: Fix included in openstack/keystone 10.0.0.0rc1

#15

This issue was fixed in the openstack/keystone 10.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-26: Fix included in openstack/mistral 3.0.0.0rc1

#16

This issue was fixed in the openstack/mistral 3.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-26: Fix included in openstack/searchlight 1.0.0.0rc1

#17

This issue was fixed in the openstack/searchlight 1.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-30: Fix merged to python-fuelclient (master)

#18

Reviewed: https://review.openstack.org/365193
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=2a0d010f5a9e22042ed1ab0b194484663fa55766
Submitter: Jenkins
Branch: master

commit 2a0d010f5a9e22042ed1ab0b194484663fa55766
Author: Ji-Wei <email address hidden>
Date: Sat Sep 3 12:32:51 2016 +0800

Raise NotImplementedError instead of NotImplemented

    NotImplementedError is the name of the exception
    (https://docs.python.org/2/library/exceptions.html).
    NotImplemented is the name of a constant
    (https://docs.python.org/2/library/constants.html).

    >>> raise NotImplemented()
    Traceback (most recent call last):
      File "<pyshell#31>", line 1, in <module>
        raise NotImplemented()
    TypeError: 'NotImplementedType' object is not callable
    >>> raise NotImplementedError()
    Traceback (most recent call last):
      File "<pyshell#32>", line 1, in <module>
        raise NotImplementedError()
    NotImplementedError

This patch fix it.

Change-Id: Ia8bf7d75cd7f70e503b9669fc60ea9d89642489b
Closes-Bug: #1339855

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-10: Fix included in openstack/keystoneauth 2.13.0

#19

This issue was fixed in the openstack/keystoneauth 2.13.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-10: Fix included in openstack/keystonemiddleware 4.10.0

#20

This issue was fixed in the openstack/keystonemiddleware 4.10.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-13: Fix included in openstack/networking-bgpvpn 5.0.0

#21

This issue was fixed in the openstack/networking-bgpvpn 5.0.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-18: Fix included in openstack/cinder 9.0.0.0rc1

#22

This issue was fixed in the openstack/cinder 9.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-18: Fix included in openstack/keystone 10.0.0.0rc1

#23

This issue was fixed in the openstack/keystone 10.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-18: Fix included in openstack/mistral 3.0.0.0rc1

#24

This issue was fixed in the openstack/mistral 3.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-18: Fix included in openstack/searchlight 1.0.0.0rc1

#25

This issue was fixed in the openstack/searchlight 1.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-10: Fix included in openstack/keystonemiddleware 4.10.0

#26

This issue was fixed in the openstack/keystonemiddleware 4.10.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-17: Fix included in openstack/heat 8.0.0.0b1

#27

This issue was fixed in the openstack/heat 8.0.0.0b1 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-17: Fix included in openstack/os-net-config 6.0.0.0b1

#28

This issue was fixed in the openstack/os-net-config 6.0.0.0b1 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-21: Fix included in openstack/networking-bgpvpn 5.0.0

#29

This issue was fixed in the openstack/networking-bgpvpn 5.0.0 release.

Ji.Wei (jiwei) on 2018-03-05

Changed in warm:
assignee:	Ji.Wei (jiwei) → nobody
Changed in solar:
assignee:	Ji.Wei (jiwei) → nobody

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-03-13: Change abandoned on solar (master)

#30

Change abandoned by JiWei (<email address hidden>) on branch: master
Review: https://review.openstack.org/365187

neutron

Raise NotImplementedError instead of NotImplemented

Bug Description

Other bug subscribers

Remote bug watches

	Status	Importance	Assigned to	Milestone
CloudCafe	Fix Committed	Undecided	Unassigned
Fuel for OpenStack	Fix Committed	Medium	Christian Berendt	Fuel for OpenStack 5.1
OpenStack Heat	Fix Released	Undecided	Ji.Wei
OpenStack Identity (keystone)	Fix Released	Medium	Ji.Wei	OpenStack Identity (keystone) newton-rc1 "RC1"
Solar	In Progress	Undecided	Unassigned
Warm	Invalid	Undecided	Unassigned
keystonemiddleware	Fix Released	Undecided	Jamie Lennox
neutron	Fix Released	Undecided	Christian Berendt	neutron 2014.2 "juno"