ML2 plugin update_port changes binding:profile when not changed

Bug #1338202 reported by Irena Berezovsky
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Irena Berezovsky

Bug Description

On port-update call, ML2 plugin considers port binding:profile is set to None, when actually there was no intention to change it.
Can be reproduced by setting admin_state_up:
neutron port-update PORT_ID --admin_state_up=False.

To fix, ML2 plugin should change its check for binding:profile setting; instead of:

profile_set = profile is not attributes.ATTR_NOT_SPECIFIED

it should be:

profile_set = attributes.is_attr_set(profile) and profile

Tags: ml2
tags: added: ml2
Itzik Brown (itzikb1)
Changed in neutron:
status: New → Confirmed
Changed in neutron:
assignee: nobody → Irena Berezovsky (irenab)
Shiv Haris (shh)
Changed in neutron:
milestone: none → juno-2
importance: Undecided → Medium
Kyle Mestery (mestery)
Changed in neutron:
milestone: juno-2 → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/108984

Changed in neutron:
status: Confirmed → In Progress
Shiv Haris (shh)
Changed in neutron:
milestone: juno-3 → juno-2
Kyle Mestery (mestery)
Changed in neutron:
milestone: juno-2 → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/108984
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cbaa3fe07b68e650d7c7714775e56f4e28c3af82
Submitter: Jenkins
Branch: master

commit cbaa3fe07b68e650d7c7714775e56f4e28c3af82
Author: Irena Berezovsky <email address hidden>
Date: Tue Jul 22 18:13:00 2014 +0300

    Fix ML2 Plugin binding:profile update

    The current fix changes the logic for binding:profile
    update. The binding:profile should be considered as changed
    once it is present in the port attributes and differs from
    existing binding:profile. The specified binding:profile with
    None value should be treated as request to clear binding:profile.

    Change-Id: Ibda9a1beec697fbee5be0ee379349035c3626509
    Closes-Bug: 1338202

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.