migration default value not being applied to dbase

[Paul Michali]

I have a private repo that is a few weeks behind the upstream, and was having problems stacking. Initially it was failing in one of the migrations, so I changed the SQLAlchemy version to 0.8.4 and alembic to 0.6.5 and retried (clean database).

What I saw was that the migration worked, but later a router create failed. It was complaining that the enable_snat field was not specified and did not have a default value. Checking in the migrations, I saw that 128e042a2b68_ext_gw_mode.py adds this field and sets the default value to True. However, it was not doing that.

I changed the migration file to use server_default=sa.text("true") and now the migration works. BTW, it was the only migration file using 'default=True'.

Not sure if we should just apply this change to the existing migration file or if some other action is needed.

[Eugene Nikanorov (enikanorov)]

has the same issue: 40b0aff0302e_mlnx_initial.py

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/105212

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/105212
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b98dda29c9bf2587c2eddad0231e337a1cb4ce02
Submitter: Jenkins
Branch: master

commit b98dda29c9bf2587c2eddad0231e337a1cb4ce02
Author: Sergey Kolekonov <email address hidden>
Date: Mon Jul 7 19:22:25 2014 +0400

    Fix missing migration default value

    Fix 128e042a2b68_ext_gw_mode and 40b0aff0302e_mlnx_initial
    migrations by properly using server_default parameter in column
    definitions.

    Change-Id: I199e206dccc36fcfc2457a17167c76611d69784a
    Closes-bug: #1336556