Inconsistent keyword for automatic deletion of resources during unit tests

[Assaf Muller]

Ports, networks and subnets have a do_delete=True parameter. By default, these resources are deleted at the end of the context manager scope. All other resources use a different semantic: no_delete=False.

This causes confusing situations such as:
with self.subnet(network, do_delete=False) as subnet:
    with self.security_group(no_delete=True) as sg:
        pass

I personally fell to the pitfall of using do_delete for the security group and was surprised when it wasn't deleted at the end of the scope.

Finally, the double negative of no_delete=False is confusing and should be avoided.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/92013
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=69dfbd9468282f9ce16cc5b0cb1bcb121632a0d8
Submitter: Jenkins
Branch: master

commit 69dfbd9468282f9ce16cc5b0cb1bcb121632a0d8
Author: Assaf Muller <email address hidden>
Date: Sun May 4 18:26:43 2014 +0300

    Change all occurences of no_delete to do_delete

    Previously, ports, networks and subnets had a do_delete=True
    parameter. By default, these resources were deleted at the
    end of the context manager scope. All other resources used
    a different semantic: no_delete=False.

    This caused confusing situations such as:
    with self.subnet(network, do_delete=False) as subnet:
        with self.security_group(no_delete=True) as sg:
            pass

    Now all resources use the same do_delete semantic.

    Closes-Bug: #1336196
    Change-Id: I4627481813f714819efe85831e2a55975ea71ed4