neutron

NSX: raise when the dscp is specified and qos_marking is trusted

Bug #1332062 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Salvatore Orlando
neutron 2014.2 "juno"
Icehouse
Fix Released
Undecided
Unassigned
neutron 2014.1.2

Bug Description

The plugin currently just logs the information and creates a queue without dscp setting.
This result in the creation of an object which differs from the user request.

It would be more correct to raise a 400 error to notify the user of the invalid setting.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/101201

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/101201
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f24482b18428a4935cbda97f96532e7c0876d9bd
Submitter: Jenkins
Branch: master

commit f24482b18428a4935cbda97f96532e7c0876d9bd
Author: Salvatore Orlando <email address hidden>
Date: Thu Jun 19 05:49:18 2014 -0700

    NSX: return 400 if dscp set for trusted queue

    If qos_marking is set to True, the code currently silently
    drops the dscp setting and continues.

    It is preferrable instead to notify the user of the invalid
    setting returning a 400 error.

    Change-Id: I7db1867712bd20f2030c56a42baac20e6ae76d0d
    Closes-Bug: 1332062

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/105619

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/105619
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0459a6a88fa58754f8184236a8d7c9cf137103cb
Submitter: Jenkins
Branch: stable/icehouse

commit 0459a6a88fa58754f8184236a8d7c9cf137103cb
Author: Salvatore Orlando <email address hidden>
Date: Thu Jun 19 05:49:18 2014 -0700

    NSX: return 400 if dscp set for trusted queue

    If qos_marking is set to True, the code currently silently
    drops the dscp setting and continues.

    It is preferrable instead to notify the user of the invalid
    setting returning a 400 error.

    Change-Id: I7db1867712bd20f2030c56a42baac20e6ae76d0d
    Closes-Bug: 1332062
    (cherry picked from commit f24482b18428a4935cbda97f96532e7c0876d9bd)

tags: added: in-stable-icehouse
Russell Bryant (russellb)
Changed in neutron:
status: Fix Committed → Fix Released
Chuck Short (zulcss)
tags: removed: icehouse-backport-potential
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.