neutron

type_tunnel.TunnelRpcCallbackMixin __init__ method incompatible with other mixins

Bug #1332041 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Kevin Benton
neutron 2014.2 "juno"

Bug Description

The init method in type_tunnel.TunnelRpcCallbackMixin expects extra parameters[1] not passed to the rest of the RPC mixins so it requires a custom __init__ method in the ML2 plugin[2].

1. https://github.com/openstack/neutron/blob/caf60442247ef0a13595db2691733f3b7589d24f/neutron/plugins/ml2/rpc.py#L54
2. https://github.com/openstack/neutron/blob/0755e7b379232285e434d827eeb854260a1db595/neutron/plugins/ml2/drivers/type_tunnel.py#L90

OpenStack Infra (hudson-openstack)
Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/101121
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e8b9a11fd728d287a1c64aa025ebba009bf5025e
Submitter: Jenkins
Branch: master

commit e8b9a11fd728d287a1c64aa025ebba009bf5025e
Author: Kevin Benton <email address hidden>
Date: Thu Jun 19 00:19:28 2014 -0700

    Remove __init__ method from TunnelCallback mixin

    Removed an __init__ method from a mixin class that
    made mixing with other classes fragile and inflexible.
    This replaces it with an explicit setup method.

    This allows the ML2 RPCCallbacks class to correctly
    inherit the common RpcCallback class.

    Closes-Bug: #1332041
    Change-Id: I36cb7dcf57147468f252d61f846b2b28dd77c8ff

Changed in neutron:
status: In Progress → Fix Committed
Russell Bryant (russellb)
Changed in neutron:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.