remove select for update lock from db_base_plugin

Bug #1331564 reported by Rossella Sblendido
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Undecided
Rossella Sblendido

Bug Description

MySQL Galera does not support SELECT ... FOR UPDATE[1], since it has no concept of cross-node locking of records and results are non-deterministic.

Remove the use of SELECT FOR UPDATE in the db_base_plugin

[1]http://lists.openstack.org/pipermail/openstack-dev/2014-May/035264.html

Tags: db Edit Tag help
Changed in neutron:
assignee: nobody → Rossella Sblendido (rossella-o)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/100963

Changed in neutron:
status: New → In Progress
Revision history for this message
Eugene Nikanorov (enikanorov) wrote :

I would suggest to actually file a blueprint for this, as this is quite a big task for the bug.

tags: added: db
Changed in neutron:
assignee: Rossella Sblendido (rossella-o) → Carl Baldwin (carl-baldwin)
Changed in neutron:
assignee: Carl Baldwin (carl-baldwin) → Rossella Sblendido (rossella-o)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/122458
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=be6c51ccd72a3cea02e5feef1b6162b451a88bd1
Submitter: Jenkins
Branch: master

commit be6c51ccd72a3cea02e5feef1b6162b451a88bd1
Author: rossella <email address hidden>
Date: Tue Sep 16 22:30:12 2014 +0000

    Remove SELECT FOR UPDATE from delete_network and delete_subnet

    delete_network and delete_subnet instead of using SELECT FOR UPDATE
    delete the ports that are allowed to be auto deleted straight away.
    Then a check is performed, if there are ports still associated
    with the network or the subnet that cannot be autodeleted,
    an exception is raised. The operation will be rolled back.

    Partial-bug: #1331564

    Change-Id: I29178204b3a220c1c6010f59272981fb1b4099fe

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/124136
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c86b8f224831ab9171ac638f1ed5585d903f0be9
Submitter: Jenkins
Branch: master

commit c86b8f224831ab9171ac638f1ed5585d903f0be9
Author: rossella <email address hidden>
Date: Tue Sep 23 11:02:20 2014 +0200

    Functional test IPAM DB operation

    Add a functional test to check that the IPAM logic is correct and
    that the data stored in the DB are sane.

    Partial-bug: #1331564
    Change-Id: I7776a50824184663abd37e210d08a63eb5519cea

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Kyle Mestery (<email address hidden>) on branch: master
Review: https://review.openstack.org/100963
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers