Fix dhcp agent scheduler to be resistant to race coditions

Bug #1331456 reported by Eugene Nikanorov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Eugene Nikanorov

Bug Description

DHCP ChanceScheduler has _schedule_bind_network method which can detect duplicate entry.

Need to add the same ability to auto_schedule_networks.

That might be important for the case when api server and rpc_server run in different processes.

Tags: l3-ipam-dhcp
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/100903

Changed in neutron:
status: New → In Progress
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → juno-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/100903
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3867174bc82b7fd85dd79bc0cc5625a15df2d8fb
Submitter: Jenkins
Branch: master

commit 3867174bc82b7fd85dd79bc0cc5625a15df2d8fb
Author: Eugene Nikanorov <email address hidden>
Date: Wed Jun 18 17:02:42 2014 +0400

    Fix auto_schedule_networks to resist DBDuplicateEntry

    This exception may happen if API and RPC workers are in different
    processes.
    Also make minor refactoring of auto_schedule_networks method
    to avoid unnecessary db queries.
    Add missing unit tests and adjust unit test naming style

    Change-Id: I6460744e2cffec0b9f009da071597374d8c027f6
    Closes-Bug: #1331456

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.