BSN: Capabilities check double-json parse

Bug #1326173 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Kevin Benton
Icehouse
Fix Released
Undecided
Unassigned

Bug Description

The capabilities check in the BigSwitch server manager tries to call json.loads on an object that has already been decoded and fails. This
causes the servers to have an empty capability list so none of the newer features are leveraged.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/97655

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
status: New → In Progress
tags: added: icehouse-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/97658

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/97655
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=63d271d4e4a8bab947f90f457ed176e46135d39e
Submitter: Jenkins
Branch: master

commit 63d271d4e4a8bab947f90f457ed176e46135d39e
Author: Kevin Benton <email address hidden>
Date: Mon Jun 2 21:39:51 2014 -0700

    Big Switch: fix capabilities retrieval code

    References the raw REST response in the capabilities
    parsing code so json.loads doesn't get an object
    that may already be decoded and fail.

    Closes-Bug: #1326173
    Change-Id: Ia3179b7499f35a6ab2e9ce1631ab15ed27d64647

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → juno-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/97658
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5285164260f5e6e40f97eaf75b629adc9b55358b
Submitter: Jenkins
Branch: stable/icehouse

commit 5285164260f5e6e40f97eaf75b629adc9b55358b
Author: Kevin Benton <email address hidden>
Date: Mon Jun 2 21:39:51 2014 -0700

    Big Switch: fix capabilities retrieval code

    References the raw REST response in the capabilities
    parsing code so json.loads doesn't get an object
    that may already be decoded and fail.

    Conflicts:
     neutron/tests/unit/bigswitch/test_capabilities.py
     neutron/tests/unit/bigswitch/test_servermanager.py

    Closes-Bug: #1326173
    Change-Id: Ia3179b7499f35a6ab2e9ce1631ab15ed27d64647

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.