| 2014-06-29 15:33:58 |
Assaf Muller |
description |
neutron/agent/linux/ovs_lib:ofctl_arg_supported executes an ovs-ofctl command and catches the general Exception, concluding that the feature is not supported. However, unexpected exceptions may be raised, swallowed and never logged. So, for example, if an OVS agent starts up and arp_responder is True, then the capabilities test for it may fail in an unexpected way. The result is that arp_responder will not be supported, the agent will start and the exception will not be printed, masking a potential bug. |
neutron/agent/linux/ovs_lib:ofctl_arg_supported executes an ovs-ofctl command and catches the general Exception, concluding that the feature is not supported. However, unexpected exceptions may be raised, swallowed and never logged. So, for example, if an OVS agent starts up and arp_responder is True, then the capabilities test for it may fail in an unexpected way. The result is that arp_responder will not be supported, the agent will start and the exception will not be printed, masking a potential bug.
Additionally, the capability test should be moved to the offline sanity command. |
|
