Cisco VPN move URI strings to constants

Bug #1313801 reported by Paul Michali
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Sridhar Ramaswamy

Bug Description

Colocate strings used in REST client methods as URIs for APIs to Cisco CSR device, to make it easier to find and maintain them. File is:

neutron/services/vpn/device_drivers/cisco_csr_rest_client.py

Tags: vpnaas
tags: added: vpnaas
Changed in neutron:
importance: Undecided → Low
Nachi Ueno (nati-ueno)
Changed in neutron:
status: New → Confirmed
Changed in neutron:
assignee: nobody → Sridhar Ramaswamy (srramasw)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/111122

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/111122
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ba87499dda0c897aa08afadfc2911ff80bdae2f9
Submitter: Jenkins
Branch: master

commit ba87499dda0c897aa08afadfc2911ff80bdae2f9
Author: Sridhar Ramaswamy <email address hidden>
Date: Sat Aug 2 16:06:58 2014 -0700

    Move Cisco VPN RESTapi URI strings to constants

    Cisco VPN RESTapi URI strings are currently spread out
    throughout the cisco vpn device driver code. This create
    challenge towards consistently using REST resource identifiers
    as this code gets enhanced in the future. This change moves
    those URIs as string contents towards the top of the device
    driver file.

    This addresses the review comment received during the
    cisco-vpnaas BP implementation.

    Change-Id: I17e02cca95b1d14d9218f1a2745780bd14c9f89d
    Closes-Bug: #1313801

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.