Setting gateway in L3 should use "replace default via ..." instead of add.

Bug #1312402 reported by Carl Baldwin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Carl Baldwin

Bug Description

Just came across this. I noticed that the ip_lib.py code uses replace instead of add. Using the common code would be good anyway.

Tags: l3-ipam-dhcp
Kyle Mestery (mestery)
Changed in neutron:
importance: Undecided → Medium
assignee: nobody → Carl Baldwin (carl-baldwin)
Changed in neutron:
milestone: none → juno-1
tags: added: l3-ipam-dhcp
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/90210
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9e1c61b93ab3523bc1b5510775c1ee3331097f21
Submitter: Jenkins
Branch: master

commit 9e1c61b93ab3523bc1b5510775c1ee3331097f21
Author: Carl Baldwin <email address hidden>
Date: Thu Apr 24 19:50:43 2014 +0000

    Use set_gateway from ip_lib

    Change-Id: I7df0f2b09a0d312902fc4745e0a245b5756074d9
    Closes-Bug: #1312402

Changed in neutron:
status: New → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/icehouse)

Change abandoned by Kyle Mestery (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/116888
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.