netaddr raises ValueError in 0.7.10 and AddrFormatError in 0.7.11

Bug #1308675 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Aaron Rosen
Havana
Fix Released
Undecided
Unassigned
Icehouse
Fix Released
Undecided
Sridhar Gaddam

Bug Description

netaddr raises ValueError in 0.7.10 and AddrFormatError in 0.7.11

Aaron Rosen (arosen)
Changed in neutron:
assignee: nobody → Aaron Rosen (arosen)
importance: Undecided → High
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/88052

Changed in neutron:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/88053

Aaron Rosen (arosen)
tags: added: havana-backport-potential icehouse-backport-potential
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/88058

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/88052
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dd2ccd12adfb6c7d4aa500ba4120f767beeed35c
Submitter: Jenkins
Branch: master

commit dd2ccd12adfb6c7d4aa500ba4120f767beeed35c
Author: Aaron Rosen <email address hidden>
Date: Wed Apr 16 11:31:25 2014 -0700

    netaddr<=0.7.10 raises ValueError instead of AddrFormatError

    This patch ensures that ValueError is also caught in addition to
    AddrFormatError as in netaddr>=0.7.11 AddrFormatError is raised and
    in netaddr<=0.7.10 ValueError is raised.

    Change-Id: I595c90e42129a2d365f3860e3042e826bd031365
    Closes-bug: #1308675

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/88606

Revision history for this message
Sridhar Gaddam (sridhargaddam) wrote :

Hi Aaron,

While looking at the Neutron code, I noticed that the same change is required at two other places.
Submitted a patch with the changes - https://review.openstack.org/#/c/88606

Regards,
--Sridhar.

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/88606
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7305ace9f37719f47d55743c0dece7089c063b12
Submitter: Jenkins
Branch: master

commit 7305ace9f37719f47d55743c0dece7089c063b12
Author: sridhargaddam <email address hidden>
Date: Fri Apr 18 21:01:48 2014 +0530

    netaddr<=0.7.10 raises ValueError instead of AddrFormatError

    This patch is based on Aarons work for the Bug#1308675.
    It ensures that ValueError is also caught in addition to
    AddrFormatError as in netaddr>=0.7.11 AddrFormatError is raised and
    in netaddr<=0.7.10 ValueError is raised.

    Change-Id: I71cfe82e57290552fb22637ad929747a6fa22460
    Closes-bug: #1308675

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/88675

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/88675
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=42a8539d497322716df0150c2123befd246d69d8
Submitter: Jenkins
Branch: stable/icehouse

commit 42a8539d497322716df0150c2123befd246d69d8
Author: Aaron Rosen <email address hidden>
Date: Wed Apr 16 11:31:25 2014 -0700

    netaddr<=0.7.10 raises ValueError instead of AddrFormatError

    This patch ensures that ValueError is also caught in addition to
    AddrFormatError as in netaddr>=0.7.11 AddrFormatError is raised and
    in netaddr<=0.7.10 ValueError is raised.

    Change-Id: I595c90e42129a2d365f3860e3042e826bd031365
    Closes-bug: #1308675
    (cherry picked from commit dd2ccd12adfb6c7d4aa500ba4120f767beeed35c)

tags: added: in-stable-icehouse
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (stable/havana)

Reviewed: https://review.openstack.org/88058
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=509d37c84f397a97ca8896309f916c47afe873e6
Submitter: Jenkins
Branch: stable/havana

commit 509d37c84f397a97ca8896309f916c47afe873e6
Author: Aaron Rosen <email address hidden>
Date: Wed Apr 16 11:31:25 2014 -0700

    netaddr<=0.7.10 raises ValueError instead of AddrFormatError

    This patch ensures that ValueError is also caught in addition to
    AddrFormatError as in netaddr>=0.7.11 AddrFormatError is raised and
    in netaddr<=0.7.10 ValueError is raised.

    Change-Id: I595c90e42129a2d365f3860e3042e826bd031365
    Closes-bug: #1308675
    (cherry picked from commit dd2ccd12adfb6c7d4aa500ba4120f767beeed35c)

tags: added: in-stable-havana
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → juno-1
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/101769

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/icehouse)

Reviewed: https://review.openstack.org/101769
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2a79749c8b09938b5ec2d94c11bac7a013c03843
Submitter: Jenkins
Branch: stable/icehouse

commit 2a79749c8b09938b5ec2d94c11bac7a013c03843
Author: sridhargaddam <email address hidden>
Date: Fri Apr 18 21:01:48 2014 +0530

    netaddr<=0.7.10 raises ValueError instead of AddrFormatError

    This patch is based on Aarons work for the Bug#1308675.
    It ensures that ValueError is also caught in addition to
    AddrFormatError as in netaddr>=0.7.11 AddrFormatError is raised and
    in netaddr<=0.7.10 ValueError is raised.

    Change-Id: I71cfe82e57290552fb22637ad929747a6fa22460
    Closes-bug: #1308675
    (cherry picked from commit 7305ace9f37719f47d55743c0dece7089c063b12)

Chuck Short (zulcss)
tags: removed: icehouse-backport-potential
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers