invalid gre/vxlan id shouldn't be created successfully for ml2

Bug #1306488 reported by Xurong Yang
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Romil Gupta

Bug Description

create vxlan successfully with invalid vxlan id for ml2:
curl -i http://127.0.0.1:9696/v2.0/networks -H "X-Auth-Token:$token_id" -H "Content-Type: application/json" -X POST -d '{"network": {"name": "vxlan_test", "admin_state_up": true, "tenant_id": $tenant_id, "provider:network_type": "vxlan", "router:external": false, "shared": false, "provider:segmentation_id": -1}}'

response:
HTTP/1.1 201 Created
Content-Type: application/json; charset=UTF-8
Content-Length: 332
X-Openstack-Request-Id: req-1e9af36d-b742-4c76-bfdf-0cea4df6399f
Date: Fri, 11 Apr 2014 09:25:51 GMT

{
    "network": {
        "status": "ACTIVE",
         "subnets": [

        ],
         "name": "vxlan_test",
         "provider:physical_network": null,
         "admin_state_up": true,
         "tenant_id": "bfed9cd5990c49ad8a42ba36d505c003",
         "provider:network_type": "vxlan",
         "router:external": false,
         "shared": false,
         "id": "5bd9b587-02f8-4432-b0d0-18a126126072",
         "provider:segmentation_id": -1
    }
}

Tags: api ml2
Xurong Yang (idopra)
Changed in neutron:
assignee: nobody → Xurong Yang (idopra)
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89982

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
milestone: none → juno-1
Assaf Muller (amuller)
summary: - invalid vxlan id shouldn't be created successfully for ml2
+ invalid gre/vxlan id shouldn't be created successfully for ml2
tags: added: api ml2
Kyle Mestery (mestery)
Changed in neutron:
milestone: juno-1 → juno-2
Kyle Mestery (mestery)
Changed in neutron:
milestone: juno-2 → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/114605

Changed in neutron:
assignee: Xurong Yang (idopra) → Romil Gupta (romilg)
Revision history for this message
Romil Gupta (romilg) wrote :

As discussed with Yang via mail.

I am going to continue working on this bug from his patch set i.e

Fix proposed to branch: master

Review: https://review.openstack.org/#/c/89982/.

I request reviewers to share comments on it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Romil Gupta (<email address hidden>) on branch: master
Review: https://review.openstack.org/114605
Reason: As discussed with Yang via mail.

I am going to continue working on this bug from his patch set i.e

Fix proposed to branch: master

Review: https://review.openstack.org/#/c/89982/

I request reviewers to share comments on it.

Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-3 → juno-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/89982
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=22bec67395b52a879ad4eb37b150eead9d4bb444
Submitter: Jenkins
Branch: master

commit 22bec67395b52a879ad4eb37b150eead9d4bb444
Author: yangxurong <email address hidden>
Date: Thu Apr 24 09:26:22 2014 +0800

    Tunnel ID range validation for VXLAN/GRE networks

    Currently, there is no check which validates the values of
    tunnel range for VXLAN/GRE networks. The VXLAN VNI is 24 bit
    which have range between 1 to 2^24 - 1. Similarly, GRE key field
    is 32 bit which have range between 1 to 2^32 - 1.

    Closes-Bug: #1306488

    Co-Authored-By: romilg <email address hidden>

    Change-Id: Idb3d0f41166df589a1e90394d9319901b5f9b439

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.