neutron

test that inherit from BaseTestCase don't need to clean up the mock.patches

Bug #1305656 reported by Rossella Sblendido
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Rossella Sblendido
neutron 2014.2 "juno"

Bug Description

In BaseTestCase a clean up is added to stop all patches :

self.addCleanup(mock.patch.stopall)

the tests that inherits from BaseTestCase don't need to stop their patches

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/86538

Changed in neutron:
assignee: nobody → Rossella Sblendido (rossella-o)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/86538
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1e0ea5217a93fadb915c3dcdf4c260738bed70ac
Submitter: Jenkins
Branch: master

commit 1e0ea5217a93fadb915c3dcdf4c260738bed70ac
Author: rossella <email address hidden>
Date: Thu Apr 10 09:33:43 2014 +0000

    Remove mock.patch.stop from tests that inherit from BaseTestCase

    The tests that inherit from BaseTestCase don't need to stop their
    patches, since this is already done in the base class

    Change-Id: Ibb1183e521686d6e948046997b32f4044d91d9e7
    Closes-bug: #1305656

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.