dhcp agent sometimes fail to add gateway to interface because interface is down

[Aaron Rosen]

2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent File "/opt/stack/neutron/neutron/agent/linux/ip_lib.py", line 217, in _as_root
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent kwargs.get('use_root_namespace', False))
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent File "/opt/stack/neutron/neutron/agent/linux/ip_lib.py", line 70, in _as_root
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent namespace)
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent File "/opt/stack/neutron/neutron/agent/linux/ip_lib.py", line 81, in _execute
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent root_helper=root_helper)
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent File "/opt/stack/neutron/neutron/agent/linux/utils.py", line 75, in execute
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent raise RuntimeError(m)
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent RuntimeError:
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent Command: ['sudo', '/usr/local/bin/neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'ip', 'netns', 'exec', 'qdhcp-e1eaed6e-ef91-4741-acb2-62daba3ffede', 'ip', 'route', 'replace', 'default', 'via', '10.2.0.1', 'dev', 'tapb1e4235c-4e']
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent Exit code: 2
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent Stdout: ''
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent Stderr: 'RTNETLINK answers: Network is unreachable\n'
2014-04-03 20:37:02.020 TRACE neutron.agent.dhcp_agent

[Aaron Rosen (arosen)]

The dhcp-agent continues to loop endlessly resyncing due to this. If i bring the interface up in the namespace the next time looped through the error goes away.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/85749

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/85749
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4e9d4824050eedfd1495469a69e28864b6fec757
Submitter: Jenkins
Branch: master

commit 4e9d4824050eedfd1495469a69e28864b6fec757
Author: rossella <email address hidden>
Date: Mon Apr 7 15:53:34 2014 +0000

    DHCP agent should check interface is UP before adding route

    The DHCP agent should check not only that an interface for
    network's DHCP exists but also make sure that is UP before
    adding a default route.
    For this purpose a method "ensure_device_is_ready" was
    added to ip_lib.

    Change-Id: I9af06aa0f39634fe7b63c064337cd4191db5c026
    Closes-bug: #1302312