neutron

test_iptables_firewall uses invalid MAC addresses

Bug #1302282 reported by Brian Haley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Brian Haley
neutron 2014.1 "icehouse"

Bug Description

The unit test test_iptables_firewall.py has invalid MAC addresses in the code - 'ff:ff:ff:ff', an actual MAC has 6 octets and should be 'ff:ff:ff:ff:ff:ff'. The test still seems to run fine, but it should be cleaned-up.

Tags: unittest
Brian Haley (brian-haley)
Changed in neutron:
assignee: nobody → Brian Haley (brian-haley)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/85216

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/85216
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5f042a64308cb00698b454da09b4a87f2ac3fafd
Submitter: Jenkins
Branch: master

commit 5f042a64308cb00698b454da09b4a87f2ac3fafd
Author: Brian Haley <email address hidden>
Date: Mon Mar 31 12:14:59 2014 -0400

    Fix test MAC addresses to be valid

    MAC addresses should have 6 octets - 'ff:ff:ff:ff:ff:ff'.

    Change-Id: I9c2457d978ccce15549d3258961093a130375bff
    Closes-bug: #1302282

Changed in neutron:
status: In Progress → Fix Committed
Mark McClain (markmcclain)
Changed in neutron:
importance: Undecided → Low
tags: added: unittest
Changed in neutron:
milestone: none → icehouse-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/85508

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (milestone-proposed)

Reviewed: https://review.openstack.org/85508
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ee1209fb9d3474c7cdf217d911b6cf7119e5676e
Submitter: Jenkins
Branch: milestone-proposed

commit ee1209fb9d3474c7cdf217d911b6cf7119e5676e
Author: Brian Haley <email address hidden>
Date: Mon Mar 31 12:14:59 2014 -0400

    Fix test MAC addresses to be valid

    MAC addresses should have 6 octets - 'ff:ff:ff:ff:ff:ff'.

    Change-Id: I9c2457d978ccce15549d3258961093a130375bff
    Closes-bug: #1302282
    (cherry picked from commit 5f042a64308cb00698b454da09b4a87f2ac3fafd)

Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-rc2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.