l3 agent uses method concatenating two constants

Bug #1302007 reported by Jakub Libosvar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Jakub Libosvar

Bug Description

In l3 agent is method ns_name() that concatenates constant NS_PREFIX with router.id that doesn't change during router's lifecycle. It's ineffective, namespace name can be an instance attribute.

Tags: l3-ipam-dhcp
Changed in neutron:
assignee: nobody → Jakub Libosvar (libosvar)
status: New → In Progress
Kyle Mestery (mestery)
Changed in neutron:
importance: Undecided → Low
tags: added: icehouse-backport-potential l3-ipam-dhcp
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/85051
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ceee7b4ac9d027499dfd2568868f1192bfb77879
Submitter: Jenkins
Branch: master

commit ceee7b4ac9d027499dfd2568868f1192bfb77879
Author: Jakub Libosvar <email address hidden>
Date: Thu Apr 3 14:52:59 2014 +0200

    Set ns_name in RouterInfo as attribute

    Closes-Bug: #1302007
    Change-Id: I02a9b92eea06010569d3d9c5a987e69f89b23be5

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → juno-1
tags: removed: icehouse-backport-potential
Changed in neutron:
milestone: juno-1 → icehouse-rc2
no longer affects: neutron/icehouse
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/85526

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (milestone-proposed)

Reviewed: https://review.openstack.org/85526
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=90039e87503767bafef27b90189fa47dfb7f5b21
Submitter: Jenkins
Branch: milestone-proposed

commit 90039e87503767bafef27b90189fa47dfb7f5b21
Author: Jakub Libosvar <email address hidden>
Date: Thu Apr 3 14:52:59 2014 +0200

    Set ns_name in RouterInfo as attribute

    Closes-Bug: #1302007
    Change-Id: I02a9b92eea06010569d3d9c5a987e69f89b23be5
    (cherry picked from commit ceee7b4ac9d027499dfd2568868f1192bfb77879)

Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-rc2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.