OneConvergence plugin create_network fails for external networks

[Hemanth Ravi]

create_network for networks with --router:external=True call doesn't add the network to the externalnetworks table. This is resulting in failures due to the missing entry in externalnetworks table. The reason is _process_l3_create() (called from create_network) expects to be invoked with a plugin session. Until recently process_l3_create was adding the entry to externalnetworks table even without the plugin session. Plugin third-party tests have been failing the last few days due to this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/84038

[Oleg Bondarev (obondarev)]

Hi Hemanth Ravi, please do not set status to Fix Commited until it is merged to master

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/84038
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d9eea51187ddd9b951e9943030724489f1c21a26
Submitter: Jenkins
Branch: master

commit d9eea51187ddd9b951e9943030724489f1c21a26
Author: Hemanth Ravi <email address hidden>
Date: Sun Mar 30 17:48:21 2014 -0700

    Invoke _process_l3_create within plugin session

    _process_l3_create should be invoked with a plugin session, else
    externalnetworks table is not populated for networks with
    router:external=True. Added the missing plugin session.

    Change-Id: I09c49dea9474f91a70aef829c1596fbb9089d6cf
    Closes-Bug: #1299946