Rename DEVICE_OWNER_COMPUTE_PROBE to not start with compute

Bug #1288582 reported by Aaron Rosen
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Aaron Rosen

Bug Description

    Neutron assumes that all ports with the device_owner that start with
    'compute' are ports created by nova compute. Thus, when the debug agent
    creates a port with device_owner = compute:probe the nova callback
    feature tells nova when this port is wired even though nova does not know
    about (doesn't really matter we just log an error). This patch just renames
    this device_owner to not start with compute to avoid this.

Tags: neutron-core
Aaron Rosen (arosen)
Changed in neutron:
importance: Undecided → Low
assignee: nobody → Aaron Rosen (arosen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/78533

Changed in neutron:
status: New → In Progress
tags: added: icehouse-backport-potential
tags: added: neutron-core
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/78533
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6b4fecb9de0aa80e66b31555001dca95d14c789f
Submitter: Jenkins
Branch: master

commit 6b4fecb9de0aa80e66b31555001dca95d14c789f
Author: Aaron Rosen <email address hidden>
Date: Mon Mar 31 11:03:48 2014 -0700

    Only send notifications on uuid device_id's

    Neutron assumes that all ports with the device_owner that start with
    'compute:' are ports created by nova compute. Thus, when the debug agent
    creates a port with device_owner = compute:probe the nova notifier
    feature tells nova when this port is wired even though nova does not know
    about it (doesn't really matter we just log an error). This patch adds a check
    to make sure the device_id is a uuid as nova only uses uuids and the debug
    agent uses the hostname for device_id.

    Change-Id: I04e7195a1fb30bc37e1c0141315c053174f8722c
    Closes-bug: #1288582

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → icehouse-rc2
tags: removed: icehouse-backport-potential
Changed in neutron:
importance: Low → Medium
Changed in neutron:
milestone: icehouse-rc2 → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/85499

Changed in neutron:
milestone: juno-1 → icehouse-rc2
no longer affects: neutron/icehouse
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (milestone-proposed)

Reviewed: https://review.openstack.org/85499
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a5909c079f89f86bd6ca2c764c0c94c8707a555a
Submitter: Jenkins
Branch: milestone-proposed

commit a5909c079f89f86bd6ca2c764c0c94c8707a555a
Author: Aaron Rosen <email address hidden>
Date: Mon Mar 31 11:03:48 2014 -0700

    Only send notifications on uuid device_id's

    Neutron assumes that all ports with the device_owner that start with
    'compute:' are ports created by nova compute. Thus, when the debug agent
    creates a port with device_owner = compute:probe the nova notifier
    feature tells nova when this port is wired even though nova does not know
    about it (doesn't really matter we just log an error). This patch adds a check
    to make sure the device_id is a uuid as nova only uses uuids and the debug
    agent uses the hostname for device_id.

    Change-Id: I04e7195a1fb30bc37e1c0141315c053174f8722c
    Closes-bug: #1288582
    (cherry picked from commit 6b4fecb9de0aa80e66b31555001dca95d14c789f)

Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-rc2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.