local_ip should be validated when ovs-agent starts

[Darragh O'Reilly]

https://github.com/openstack/neutron/blob/2702baed390d094b0eac07d0ae167ed236868d00/neutron/plugins/openvswitch/agent/ovs_neutron_agent.py#L1327

The ovs agent will currently accepts anything for local_ip, and sends it to the plugin with the sync_tunnels rpc, and then all other agents will try to make tunnel ports using it as the remote_ip. Then the only way to get rid of it is to manually delete the row in the DB.

If tunneling is enabled, netaddr.IPAddress() could be used to validate that local_ip is a proper IP address. Only IPv4 tunnels are currently supported for GRE - not sure about VxLAN. Maybe a check that local_ip actually exists on the host too.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/77100

[Doug Hellmann (doug-hellmann)]

https://review.openstack.org/#/c/92396/ merged in oslo.config

[Sudhakar Gariganti (sudhakar-gariganti)]

Now that we have the config value itself typechecked with oslo side enhancement, should we close the defect ?

[Jakub Libosvar (libosvar)]

I think not. Once new version of oslo.config is released we should change the type in Neutron.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/110235

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/110235
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=be6ab2449d8daeabec124c3c601f1aa2d3b5c6ec
Submitter: Jenkins
Branch: master

commit be6ab2449d8daeabec124c3c601f1aa2d3b5c6ec
Author: Jakub Libosvar <email address hidden>
Date: Tue Jul 29 10:50:12 2014 +0200

    Validate local_ip for OVS agent is actual ip address

    tunnel_sync() writes this value into ovsdb and value is not validated. In
    case non-ip value is written into ovsdb row must be deleted manually.

    Change-Id: I57eee81e6821eb2cb26b3d07a39bc94b81243570
    Closes-bug: #1284684

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kyle Mestery (<email address hidden>) on branch: master
Review: https://review.openstack.org/77100
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.